After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706136 - Wi-fi dialog tweaks
Wi-fi dialog tweaks
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-16 13:41 UTC by Allan Day
Modified: 2013-08-20 18:37 UTC
See Also:
GNOME target: 3.10
GNOME version: 3.9/3.10


Attachments
screenshot (68.21 KB, image/png)
2013-08-16 13:41 UTC, Allan Day
  Details
network: Add a selected indicator to the current access point (3.46 KB, patch)
2013-08-19 14:51 UTC, Jasper St. Pierre (not reading bugmail)
reviewed Details | Review
network: Make the Connect button insensitive when on the current network (1.10 KB, patch)
2013-08-19 14:51 UTC, Jasper St. Pierre (not reading bugmail)
reviewed Details | Review
network: Add a selected indicator to the current access point (5.00 KB, patch)
2013-08-19 15:15 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review
network: Make the Connect button insensitive when on the current network (952 bytes, patch)
2013-08-19 15:15 UTC, Jasper St. Pierre (not reading bugmail)
accepted-commit_now Details | Review

Description Allan Day 2013-08-16 13:41:02 UTC
Created attachment 251843 [details]
screenshot

Quick design review:

 * Add 6px horizontal padding between icon and text
 * Add 12px vertical padding above the list
 * Place a check mark icon to the right hand side of the connected network (this should always be at the top of the list)
 * Connect button should remain insensitive if you select the connected network
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-08-19 14:51:38 UTC
Created attachment 252236 [details] [review]
network: Add a selected indicator to the current access point
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-19 14:51:41 UTC
Created attachment 252237 [details] [review]
network: Make the Connect button insensitive when on the current network
Comment 3 Giovanni Campagna 2013-08-19 14:54:59 UTC
Review of attachment 252236 [details] [review]:

::: js/ui/status/network.js
@@ +548,3 @@
+        this._signalIcon.icon_name = this._getIcon();
+
+        if (this._ap == this._device.active_access_point)

Uhm... it's a corner case, but the device might be connected to a different, weaker, AP in the same network. I think we want the check mark in that case.
Comment 4 Giovanni Campagna 2013-08-19 14:55:35 UTC
Review of attachment 252237 [details] [review]:

::: js/ui/status/network.js
@@ +617,3 @@
+        if (this._selectedNetwork) {
+            let ap = this._selectedNetwork.accessPoints[0];
+            connectSensitive = (this._device.active_access_point != ap);

Again, the network might be the same, but the APs different.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-08-19 15:15:27 UTC
Created attachment 252238 [details] [review]
network: Add a selected indicator to the current access point
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-08-19 15:15:32 UTC
Created attachment 252239 [details] [review]
network: Make the Connect button insensitive when on the current network
Comment 7 Giovanni Campagna 2013-08-19 15:18:58 UTC
Review of attachment 252238 [details] [review]:

Ok
Comment 8 Giovanni Campagna 2013-08-19 15:20:04 UTC
Review of attachment 252239 [details] [review]:

Ok
Comment 9 Matthias Clasen 2013-08-20 15:51:32 UTC
doesn't apply cleanly to current master - can you push this, Jasper ?
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-08-20 18:37:15 UTC
I already pushed it; it seems git-bz fell through.