After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705814 - [abrt] Crash in certificate_viewer_new()
[abrt] Crash in certificate_viewer_new()
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: general
3.8.x (obsolete)
Other Linux
: Normal critical
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2013-08-12 06:20 UTC by Milan Crha
Modified: 2013-08-12 07:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
eds patch (394 bytes, patch)
2013-08-12 06:23 UTC, Milan Crha
committed Details | Review
evo patch (350 bytes, patch)
2013-08-12 07:05 UTC, Milan Crha
committed Details | Review

Description Milan Crha 2013-08-12 06:20:05 UTC
Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=995516

Description of problem:
On every startup, evolution asks me if I want to trust a certificate (i don't know why, it started recently), then I choose "show me the certicate" or whatever the button is called in english, this makes evolution-data-server crash

Version-Release number of selected component:
evolution-data-server-3.8.4-1.fc19

Additional info:
reporter:       libreport-2.1.5
backtrace_rating: 4
cmdline:        /usr/libexec/evolution-user-prompter
crash_function: certificate_viewer_new
executable:     /usr/libexec/evolution-user-prompter
kernel:         3.10.4-300.fc19.x86_64

Core was generated by `/usr/libexec/evolution-user-prompter'.
Program terminated with signal 6, Aborted.

Thread 1 (Thread 0x7fbeea62d9c0 (LWP 1626))

  • #0 __GI_raise
    at ../nptl/sysdeps/unix/sysv/linux/raise.c line 56
  • #1 __GI_abort
    at abort.c line 90
  • #2 __libc_message
    at ../sysdeps/unix/sysv/linux/libc_fatal.c line 196
  • #3 malloc_printerr
  • #4 g_free
    at gmem.c line 252
  • #5 certificate_viewer_new
    at certificate-viewer.c line 578
  • #6 trust_prompt_response_cb
    at trust-prompt-gtk.c line 111
  • #7 g_closure_invoke
    at gclosure.c line 777
  • #8 signal_emit_unlocked_R
    at gsignal.c line 3584
  • #9 g_signal_emit_valist
    at gsignal.c line 3328
  • #10 g_signal_emit
    at gsignal.c line 3384
  • #11 _g_closure_invoke_va
    at gclosure.c line 840
  • #12 g_signal_emit_valist
    at gsignal.c line 3234
  • #13 g_signal_emit
    at gsignal.c line 3384
  • #14 gtk_real_button_released
    at gtkbutton.c line 1967
  • #15 g_closure_invoke
    at gclosure.c line 777
  • #16 signal_emit_unlocked_R
    at gsignal.c line 3514
  • #17 g_signal_emit_valist
    at gsignal.c line 3328
  • #18 g_signal_emit
    at gsignal.c line 3384
  • #19 gtk_button_button_release
    at gtkbutton.c line 1802
  • #20 _gtk_marshal_BOOLEAN__BOXEDv
    at gtkmarshalers.c line 130
  • #21 _g_closure_invoke_va
    at gclosure.c line 840
  • #22 g_signal_emit_valist
    at gsignal.c line 3234
  • #23 g_signal_emit
    at gsignal.c line 3384
  • #24 gtk_widget_event_internal
    at gtkwidget.c line 6714
  • #25 gtk_widget_event
    at gtkwidget.c line 6371
  • #26 propagate_event_up
    at gtkmain.c line 2393
  • #27 propagate_event
    at gtkmain.c line 2501
  • #28 gtk_main_do_event
    at gtkmain.c line 1716
  • #29 gdk_event_source_dispatch
    at gdkeventsource.c line 364
  • #30 g_main_dispatch
    at gmain.c line 3054
  • #31 g_main_context_dispatch
    at gmain.c line 3630
  • #32 g_main_context_iterate
    at gmain.c line 3701
  • #33 g_main_loop_run
    at gmain.c line 3895
  • #34 dbus_server_run_server
    at e-dbus-server.c line 222
  • #35 ffi_call_unix64
    at ../src/x86/unix64.S line 76
  • #36 ffi_call
    at ../src/x86/ffi64.c line 522
  • #37 g_cclosure_marshal_generic_va
    at gclosure.c line 1550
  • #38 _g_closure_invoke_va
    at gclosure.c line 840
  • #39 g_signal_emit_valist
    at gsignal.c line 3234
  • #40 g_signal_emit
    at gsignal.c line 3384
  • #41 e_dbus_server_run
    at e-dbus-server.c line 414
  • #42 main
    at evolution-user-prompter.c line 73

Comment 1 Milan Crha 2013-08-12 06:23:54 UTC
Created attachment 251317 [details] [review]
eds patch

for evolution-data-server;

Stupid overlook in the code, the get_window_title() was supposed to return a newly allocated string, but for the fallback case it returned non-allocated string, which resulted in the crash on free.
Comment 2 Milan Crha 2013-08-12 07:05:22 UTC
Created attachment 251321 [details] [review]
evo patch

for evolution;

The same change comes to evolution as well.
Comment 3 Milan Crha 2013-08-12 07:08:29 UTC
Created commit c1c019e in eds master (3.9.90+)
Created commit 9b44f89 in evo master (3.9.90+)

Created commit 2bb8430 in eds gnome-3-8 (3.8.6+)
Created commit 16e19b1 in evo gnome-3-8 (3.8.6+)