GNOME Bugzilla – Bug 705446
Old POP3 mails can be removed before getting them
Last modified: 2013-08-08 06:29:44 UTC
This is hard to reproduce, but it's the second time in two months I lose all my new mails (now with 3.8.4, last time with older 3.8.x version) and I think this behavior should be double checked: Usually, this occurs when network connection is really poor, in my case, the two times it occurred was because I was using my mobile phone as wifi router and 3G connection was lost in favor of (slower) 2G. I just hit this sequence: - Evolution reports an error trying to retrieve a message (it also shows something like the message containing "[@#~11" (some random chars). - I click again on the button to get and send mails -> Evolution gets stalled trying to get them. I cannot close evolution and end up running "evolution --force-shutdown" (that looks to finally kill it) - I open evolution again (now with proper networking) -> it gets three new messages... but old previous messages were lost (probably because I have evolution configured to remove messages once they are retrieved... but they weren't really retrieved successfully and were removed from the server anyway (!). Maybe evolution shouldn't clean mails from server until they are retrieved and shown in Mailer (even after applying the filters). Otherwise, looks like it can cause data lose in some cases :|
Thanks for a bug report. I can reproduce this, if I cancel message fetching in the middle of the list to-be-downloaded, and if I restart fetching, then the old messages are removed, despite they were not downloaded yet at all (but they are old enough to satisfy the removal condition).
That is nice, I thought it was hard to reproduce and would be difficult to show you how to see the problem :'(
Created attachment 251117 [details] [review] eds patch for evolution-data-server; The POP3 provider part. It adds more checking on a cancellable and a method to recognize uncached messages. The method is needed to distinguish between already downloaded and to-be-downloaded messages.
Created attachment 251118 [details] [review] evo patch for evolution; Also add a bit more of checking on cancellables, and the most importantly save only already downloaded messages into local uid-cache file, instead of all new, which caused the POP3 to think it is already downloaded, while it really wasn't. The last part about disconnect is necessary for proper connection closing.
Created commit 2e7abcf in eds master (3.9.90+) Created commit 52a48c1 in evo master (3.9.90+) Created commit 809b48f in eds gnome-3-8 (3.8.5+) Created commit 8b8ddbd in evo gnome-3-8 (3.8.5+)
Thanks a lot for the really fast fix :D, will try them when I get proper internet connection again ;)