After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704785 - Check return value of g_dbus_connection_register_object(), use GCancellable
Check return value of g_dbus_connection_register_object(), use GCancellable
Status: RESOLVED OBSOLETE
Product: gnome-settings-daemon
Classification: Core
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-24 09:00 UTC by David King
Modified: 2019-03-20 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description David King 2013-07-24 09:00:29 UTC 
As noticed by Bastien in bug 692771, comment #20, some uses of g_dbus_connection_register_object() do not check the return value, where 0 indicates an error. The orientation plugin is one such example:

plugins/orientation/gsd-orientation-manager.c:354

Just below that call, there is a g_dbus_proxy_new() which should use a GCancellable, as should the g_bus_get() call on line 447.
Comment 1 GNOME Infrastructure Team 2019-03-20 11:10:57 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/218.