After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704631 - Ctrl+A should update the caret position
Ctrl+A should update the caret position
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks: 677348
 
 
Reported: 2013-07-21 01:45 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2018-05-22 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make all the caret cursor movements relative to the current selection (1.79 KB, patch)
2013-08-02 12:20 UTC, Antía Puentes
none Details | Review
Move the cursor to the selection limit even if the limit it is not in the current page (2.29 KB, patch)
2013-08-02 12:24 UTC, Antía Puentes
none Details | Review
Make the caret movements relative to the selection boundaries (5.42 KB, patch)
2014-07-24 16:16 UTC, Antía Puentes
none Details | Review
Make the caret movements relative to the selection boundaries (7.51 KB, patch)
2014-07-25 13:59 UTC, Antía Puentes
none Details | Review
Fix to move the caret to a selection boundary outside the current page (2.81 KB, patch)
2014-07-25 16:27 UTC, Antía Puentes
none Details | Review
Move caret by word relative to the selection (1.06 KB, patch)
2014-07-25 16:28 UTC, Antía Puentes
none Details | Review
Move the caret to prev/next line relative to the selection (1.05 KB, patch)
2014-07-25 16:29 UTC, Antía Puentes
none Details | Review
Move the caret to start/end line relative to the selection (1012 bytes, patch)
2014-07-25 16:29 UTC, Antía Puentes
none Details | Review
Select from the caret to the start/end of the document relative to the selection (2.40 KB, patch)
2014-07-25 16:35 UTC, Antía Puentes
none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2013-07-21 01:45:25 UTC
Steps to reproduce:
1. Enable caret navigation (see bug 702079)
2. Position the caret in the middle of the page
3. Press Ctrl+A to select all
4. Press a cursor-moving key to unselect the text

Expected results: The new location of the caret would be relative to the selection. Thus Home, Left, Up would set the caret at the beginning of the document; End, Right, Down would set the caret at the end of the document.
(Compare with Gedit, LibreOffice, Thunderbird, etc.)

Actual results: The new location of the caret is relative to wherever the caret was positioned in step 2.
Comment 1 Antía Puentes 2013-08-02 12:20:50 UTC
Created attachment 250685 [details] [review]
Make all the caret cursor movements relative to the current selection

In the current implementation only the cursor movements corresponding to the Right/Left arrows were relative to the current selection.

Following gedit as example, the patch makes Home/End keys, Control + Right/Left arrows and Up/Down arrows relative to the current selection.

In the case of Up/Down arrows (go to prev/next line), as gedit does, the cursor would move to the prev line of the starting point of the selection (maintaining  the start of selection offset as offset inside the line), to the next line of the end of the selection (maintaining the end of selection offset as offset inside the line).
Comment 2 Antía Puentes 2013-08-02 12:24:21 UTC
Created attachment 250687 [details] [review]
Move the cursor to the selection limit even if the limit it is not in the current page

The current implementation fails to move the cursor to the boundaries of the current selection when the corresponding selection boundary is not in the current page.

For that reason, after selecting using Control+A , to move to the limits of the selection using the Left/Right arrows fails if the document has more than one page.
Comment 3 Antía Puentes 2014-07-24 16:16:39 UTC
Created attachment 281617 [details] [review]
Make the caret movements relative to the selection boundaries

Updated patch.

It does not upload the first and last pages to the cache, information needed to position the cursor at the beggining/end of the document as this in done as part of the patch attachment 250687 [details] [review] for bug 724273
Comment 4 Antía Puentes 2014-07-25 13:59:24 UTC
Created attachment 281695 [details] [review]
Make the caret movements relative to the selection boundaries

Rebased. Also fixed the selection using <Shift><Ctrl>Home/End
Comment 5 Antía Puentes 2014-07-25 16:27:44 UTC
Created attachment 281704 [details] [review]
Fix to move the caret to a selection boundary outside the current page
Comment 6 Antía Puentes 2014-07-25 16:28:26 UTC
Created attachment 281705 [details] [review]
Move caret by word relative to the selection
Comment 7 Antía Puentes 2014-07-25 16:29:00 UTC
Created attachment 281706 [details] [review]
Move the caret to prev/next line relative to the selection
Comment 8 Antía Puentes 2014-07-25 16:29:39 UTC
Created attachment 281707 [details] [review]
Move the caret to start/end line relative to the selection
Comment 9 Antía Puentes 2014-07-25 16:35:17 UTC
Created attachment 281712 [details] [review]
Select from the caret to the start/end of the document relative to the selection
Comment 10 GNOME Infrastructure Team 2018-05-22 15:15:37 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/387.