After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702295 - Don't use EggListBox
Don't use EggListBox
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-14 22:03 UTC by Giovanni Campagna
Modified: 2013-06-14 22:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Don't use EggListBox (4.31 KB, patch)
2013-06-14 22:04 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-06-14 22:03:57 UTC
We can use GtkListBox, and remove the can of worms that EggListBox
is.
Comment 1 Giovanni Campagna 2013-06-14 22:04:00 UTC
Created attachment 246860 [details] [review]
Don't use EggListBox
Comment 2 Cosimo Cecchi 2013-06-14 22:06:01 UTC
Review of attachment 246860 [details] [review]:

Sounds great! Can you also remove m4/ax_config_dir.m4 when pushing this?

::: configure.ac
@@ +78,3 @@
                   goa-1.0 >= $GOA_MIN_VERSION
                   libgdata >= $GDATA_MIN_VERSION
+                  zapojit-0.0 >= $ZAPOJIT_MIN_VERSION)

Please require GTK+ master for this.
Comment 3 Giovanni Campagna 2013-06-14 22:14:51 UTC
Pushed with suggested changes.
Attachment 246860 [details] pushed as 0af141c - Don't use EggListBox