After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 700517 - flickr: Renaming of sources created using GOA
flickr: Renaming of sources created using GOA
Product: grilo
Classification: Other
Component: plugins
Other Linux
: Normal enhancement
: ---
Assigned To: grilo-maint
Depends on:
Blocks: 700897
Reported: 2013-05-17 11:58 UTC by Marek Chalupa
Modified: 2013-05-28 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Patch (5.35 KB, patch)
2013-05-17 12:59 UTC, Marek Chalupa
none Details | Review
Use different source naming when GOA is enabled (7.07 KB, patch)
2013-05-23 08:12 UTC, Marek Chalupa
committed Details | Review

Description Marek Chalupa 2013-05-17 11:58:33 UTC
sometimes I need use just some of sources created by GOA in flickr plugin, but there is no way how to recognize them.
Instead of hitherto naming grl-flickr-user_name, It'd be good to rename the GOA ones to grl-flickr-account_id.

I'm working on a patch.

Comment 1 Marek Chalupa 2013-05-17 12:59:01 UTC
Created attachment 244523 [details] [review]
Comment 2 Marek Chalupa 2013-05-18 13:49:16 UTC
Forget to use ENABLE_GOA macros for conditional compilation. It works even without it, but still.. I'll fix it.
Comment 3 Marek Chalupa 2013-05-23 08:12:13 UTC
Created attachment 245106 [details] [review]
Use different source naming when GOA is enabled

Here's the patch using conditional compilation
Comment 4 Juan A. Suarez Romero 2013-05-23 09:22:23 UTC
commit 6f982833955a842e0d5259516d577ec06cdd62e6
Author: Marek Chalupa <>
Date:   Thu May 23 10:01:40 2013 +0200

    flickr: name sources created from goa by their id
    When source is created from GOA config, dont use user name as a source-id
    but use goa id (account_somenumber) instead

 src/flickr/grl-flickr.c |   87 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 86 insertions(+), 1 deletion(-)