After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697027 - gucharmap-3.8 doesn't support vala-0.20
gucharmap-3.8 doesn't support vala-0.20
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
3.8.x
Other Linux
: Normal normal
: gnome-3-8
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2013-04-01 10:58 UTC by Pacho Ramos
Modified: 2013-04-15 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Pacho Ramos 2013-04-01 10:58:21 UTC 
That vala version is needed to work with gobject-introspection-1.36, the following configure check makes anjuta incompatible with it:
# No automagic please!
if test -z "$enable_vala"; then
  enable_vala=no
fi
m4_ifdef([VAPIGEN_CHECK],
  [VAPIGEN_CHECK([0.16],[0.18])],
  [AM_CONDITIONAL([ENABLE_VAPIGEN],[false])])

Can it be ported to allow 0.20 usage too?
Comment 1 Christian Persch 2013-04-01 11:34:19 UTC 
No objections. I don't have vala 0.20, so could you try to create a patch?
Comment 2 Pacho Ramos 2013-04-02 18:24:13 UTC 
this would be the patch, but I don't understand why I need to drop "0.18" to get 0.20 detected (!)
--- configure.ac~       2013-03-25 21:10:51.000000000 +0100
+++ configure.ac        2013-04-02 20:01:07.658861353 +0200
@@ -243,7 +243,7 @@
   enable_vala=no
 fi
 m4_ifdef([VAPIGEN_CHECK],
-  [VAPIGEN_CHECK([0.16],[0.18])],
+  [VAPIGEN_CHECK([0.16],[0.20])],
   [AM_CONDITIONAL([ENABLE_VAPIGEN],[false])])

 case "$with_gtk" in

If 0.18 is included in VAPIGEN_CHECK it takes full precedence, do you know why? Is it because VAPIGEN_CHECK is expecting a range of versions? (and, then, only two versions can be specified?)
Comment 3 Christian Persch 2013-04-02 18:58:11 UTC 
Those version were hardcoded by me simply because I couldn't get it to work otherwise...
Comment 4 Pacho Ramos 2013-04-02 19:32:31 UTC 
Well, it looks to work with anything above >= 0.16, in that case, of VAPIGEN_CHECK simply checks for MINIMUM versions:
[VAPIGEN_CHECK([0.16])],

should be enough
Comment 5 Pacho Ramos 2013-04-07 11:42:33 UTC 
--- configure.ac~       2013-03-25 21:10:51.000000000 +0100
+++ configure.ac        2013-04-02 20:01:07.658861353 +0200
@@ -243,7 +243,7 @@
   enable_vala=no
 fi
 m4_ifdef([VAPIGEN_CHECK],
-  [VAPIGEN_CHECK([0.16],[0.18])],
+  [VAPIGEN_CHECK([0.16])],
   [AM_CONDITIONAL([ENABLE_VAPIGEN],[false])])

 case "$with_gtk" in

This is enough
Comment 6 Christian Persch 2013-04-07 12:34:58 UTC 
gucharmap/Makefile.am hardcodes $(datadir)/vala-0.18/vapi so I presume that needs to be changed too? And then it won't work on my system anymore, since I had to make it that way to get it working...
Comment 7 Pacho Ramos 2013-04-07 12:58:29 UTC 
What failed with:
vapidir = $(datarootdir)/vala/vapi
?

(looks the way used in other apps like, for example, e-d-s)
Comment 8 Christian Persch 2013-04-15 17:17:12 UTC 
Should be fixed on master / 3.8.1.
Comment 9 Pacho Ramos 2013-04-15 20:02:12 UTC 
Thanks Christian