After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695443 - After adding too many input sources, one cannot easily remove them again
After adding too many input sources, one cannot easily remove them again
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.7.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-03-08 13:21 UTC by Mike FABIAN
Modified: 2013-03-12 14:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
after-adding-too-many-input-methods-one-cannot-remove-them.png (277.10 KB, image/png)
2013-03-08 13:21 UTC, Mike FABIAN
  Details
region: Prevent window from getting too tall with many input sources (5.18 KB, patch)
2013-03-08 23:03 UTC, Rui Matos
committed Details | Review
with-fix-by-rui-matos.png (575.72 KB, image/png)
2013-03-10 11:29 UTC, Mike FABIAN
  Details

Description Mike FABIAN 2013-03-08 13:21:49 UTC
Created attachment 238370 [details]
after-adding-too-many-input-methods-one-cannot-remove-them.png

Use “gnome-control-center region” to add input sources.

After adding one input source “too much”, the “+” and “-” buttons
at the bottom to add and remove input methods end up below the
lower end of the screen (see screen shot).

Using  Alt+F7 or right mouse click on the title bar of the window, one
can move the window, but only left, right, and down.

One cannot move the window up, the panel seems to prevent that.

So one cannot reach the “+” “-”  buttons any more, so there is no
easy way to fix that problem (changing the dconf key directly should
work but that is not “easy”).
Comment 1 Rui Matos 2013-03-08 23:03:17 UTC
Created attachment 238432 [details] [review]
region: Prevent window from getting too tall with many input sources
Comment 2 Matthias Clasen 2013-03-09 22:30:55 UTC
Should we consider this for 3.8 ?
Comment 3 Rui Matos 2013-03-09 22:53:37 UTC
(In reply to comment #2)
> Should we consider this for 3.8 ?

I think it's a nice fix to have. Technically breaks the UI freeze but only on the rare cases that people have > 5 input sources. Not sure it's worth to ask for an official approval just for that but I can do so.
Comment 4 Mike FABIAN 2013-03-10 11:29:34 UTC
Created attachment 238515 [details]
with-fix-by-rui-matos.png

I tested Rui’s fix, it looks nice.
Comment 5 Matthias Clasen 2013-03-11 03:12:06 UTC
Review of attachment 238432 [details] [review]:

Looks fairly safe to me. Need to remember to update n_input_sources when the none-removal patch lands.
Comment 6 Bastien Nocera 2013-03-11 09:44:05 UTC
Review of attachment 238432 [details] [review]:

Please move all the resize hacks into their own functions.
Comment 7 Rui Matos 2013-03-12 13:59:20 UTC
Attachment 238432 [details] pushed as 94ff113 - region: Prevent window from getting too tall with many input sources
Comment 8 Rui Matos 2013-03-12 14:03:37 UTC
(In reply to comment #6)
> Please move all the resize hacks into their own functions.

Forgot to mention that I did this before pushing.