GNOME Bugzilla – Bug 694516
gsettings values: mention dbus-launch
Last modified: 2018-03-26 14:29:40 UTC
It may make sense to mention in the d-bus footnote that you can get the required session bus by running gsettings under dbus-launch, like this: dbus-launch gsettings set org.gnome.desktop.background draw-background true
Created attachment 239444 [details] [review] a comment concerning dbus-launch added into the gsettings-browse.page
Hello, Could anybody be so kind as to review this patch? Thank you very much, jana
A development snapshot of the page is available here: http://people.gnome.org/~pmkovar/system-admin-guide/gsettings-browse.html
Review of attachment 239444 [details] [review]: ::: system-admin-guide/C/gsettings-browse.page @@ +36,3 @@ </p> + <p><app>Dconf-editor</app> may be better to use if you are not familiar with I think capitalizing is confusing here, since the name in <app> should be the actual binary name. Trying to launch Dconf-editor on the commandline will not work... @@ +39,3 @@ the options available an application. However, as a commandline application, <app>gsettings</app> is more powerful than <app>dconf-editor</app>. <app> + Gsettings</app> permits bash completion, and you can write scripts that Same here @@ +52,3 @@ + <p>You can get the required session bus by running gsettings under + <sys>dbus-launch</sys> utility, like this:</p> +<code>dbus-launch gsettings set org.gnome.desktop.background draw-background true</code> I think the new paragraph should be part of the <note>.
Created attachment 241228 [details] New gsettings-browse.page with implemented SME's comments Hello, I have implemented Matthias's comments. Here is the result ready to be reviewed. jana
Comment on attachment 241228 [details] New gsettings-browse.page with implemented SME's comments Can you please provide a patch?
Created attachment 241232 [details] [review] SME's comments have been implemented
Hello, Could anybody review this patch so that we can close it, please? Thank you for any comments, jana
Review of attachment 241232 [details] [review]: Please add the bug number to the commit title, and use a commit title which summarises what you did in the commit. If you need to, use a detailed commit message to explain what you did in more details. For example, you could have something along the lines of: "Add dbus-launch example to gsettings-browse https://bugzilla.gnome.org/show_bug.cgi?id=694516" ::: system-admin-guide/C/gsettings-browse.page @@ +39,3 @@ the options available an application. However, as a commandline application, <app>gsettings</app> is more powerful than <app>dconf-editor</app>. <app> + gsettings</app> permits bash completion, and you can write scripts that The line must not be broken between the tag and the content of the tag. Bring <app> down onto the same line as gsettings so it looks like <app>gsettings</app>. "Bash completion is provided for <app>gsettings</app>" is more accurate than what you have there. @@ +47,3 @@ + <p>You can get the required session bus by running gsettings under + <sys>dbus-launch</sys> utility, like this:</p> +<code>dbus-launch gsettings set org.gnome.desktop.background draw-background true</code> Why did you move this to here? It is related to the bus session note below. @@ +52,3 @@ <note><p>Both <app>dconf-editor</app> and <app>gsettings</app> require a D-Bus session bus in order to make any changes. This is because the <sys>dconf</sys> daemon must be activated using D-Bus.</p></note> Having two notes in a row makes them stand out less, I recommend making this just a normal paragraph instead of leaving it as a note.
Created attachment 242310 [details] [review] BZ number: 694516 style and language corrected in gsettings-browse.page Hi Kat, Thank you for your comments, I have just implemented them all! Here is a patch. I have pushed to wip/system-admin-guide. Cheers, jana
Hi Jana, looks good! You should squash your two patches before cherry-picking them to master.
These patches were pushed to master in commits 0d1715e9b63dd25cb0256b04c5b460c90d68d988 and f5114b6f8fdfbe1a29b2be8b30218fed785213b1 The current status of this page is that it needs to be rewritten from a sysadmin's point of view and is quite off topic.
Comment on attachment 242310 [details] [review] BZ number: 694516 style and language corrected in gsettings-browse.page [setting status to committed as this is https://git.gnome.org/browse/gnome-user-docs/commit/system-admin-guide/C?id=f5114b6f8fdfbe1a29b2be8b30218fed785213b1 ]
Comment on attachment 239444 [details] [review] a comment concerning dbus-launch added into the gsettings-browse.page [committed as https://git.gnome.org/browse/gnome-user-docs/commit/system-admin-guide/C?id=0d1715e9b63dd25cb0256b04c5b460c90d68d988 ]
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-user-docs/issues/3.