After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 692006 - Only show the settings button for input method engines
Only show the settings button for input method engines
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 692672
Blocks:
 
 
Reported: 2013-01-18 11:50 UTC by Allan Day
Modified: 2013-02-19 11:32 UTC
See Also:
GNOME target: ---
GNOME version: 3.7/3.8


Attachments
region: Show/hide IBus sources config button (4.44 KB, patch)
2013-02-11 18:12 UTC, Rui Matos
committed Details | Review

Description Allan Day 2013-01-18 11:50:54 UTC
This is an issue that a user pointed me to recently: we show a button for settings under the input method list, which is only sensitive for input method engines.

The problem is that it isn't clear to the user why the settings button is insensitive for keyboard layouts - they'll be asking "why can't I ever use the settings?"

A solution to this issue would be to only show the settings button for IMEs, and to hide it for keyboard layouts.

Also, the icon should probably be changed to emblem-system-symbolic - that seems to have become the standard icon for settings.
Comment 1 Rui Matos 2013-02-11 18:12:46 UTC
Created attachment 235727 [details] [review]
region: Show/hide IBus sources config button

Instead of just making it sensitive/unsensitive. Quoting from the bug
report:

The problem is that it isn't clear to the user why the settings button is
insensitive for keyboard layouts - they'll be asking "why can't I ever use the
settings?"

--

This is part of the wip/region-panel branch but I'm attaching here
since we have a specific bug report for it.
Comment 2 Bastien Nocera 2013-02-11 21:44:04 UTC
Review of attachment 235727 [details] [review]:

Looks good.