GNOME Bugzilla – Bug 691132
Use GResource for UI files and icon data
Last modified: 2013-01-07 10:15:14 UTC
Instead of installing those files directly. I am working on a patchset for this.
Created attachment 232741 [details] [review] background: use a GResource for GtkBuilder UI definition
Created attachment 232742 [details] [review] bluetooth: use a GResource for GtkBuilder UI definition
Created attachment 232743 [details] [review] color: use a GResource for GtkBuilder UI definition
Created attachment 232744 [details] [review] datetime: use a GResource for GtkBuilder UI definition and icons
Created attachment 232745 [details] [review] display: use a GResource for GtkBuilder UI definition
Created attachment 232746 [details] [review] info: use a GResource for GtkBuilder UI definition
Created attachment 232747 [details] [review] keyboard: use a GResource for GtkBuilder UI definition
Created attachment 232748 [details] [review] mouse: use a GResource for GtkBuilder UI definition and icons
Created attachment 232749 [details] [review] network: use a GResource for GtkBuilder UI definition
Created attachment 232750 [details] [review] notifications: use a GResource for GtkBuilder UI definition
Created attachment 232751 [details] [review] online-accounts: use a GResource for GtkBuilder UI definition
Created attachment 232752 [details] [review] power: use a GResource for GtkBuilder UI definition
Created attachment 232753 [details] [review] printers: use a GResource for GtkBuilder UI definition
Created attachment 232754 [details] [review] privacy: use a GResource for GtkBuilder UI definition
Created attachment 232755 [details] [review] region: use a GResource for GtkBuilder UI definition
Created attachment 232756 [details] [review] screen: use a GResource for GtkBuilder UI definition
Created attachment 232757 [details] [review] search: use a GResource for GtkBuilder UI definition
Created attachment 232758 [details] [review] universal-access: use a GResource for GtkBuilder UI definition
Created attachment 232759 [details] [review] wacom: use a GResource for GtkBuilder UI definition and icons
Created attachment 232760 [details] [review] info: remove unused code
Created attachment 232761 [details] [review] keyboard: remove unused code
Created attachment 232762 [details] [review] mouse: remove unused code
Created attachment 232763 [details] [review] screen: remove unused code
Review of attachment 232741 [details] [review]: ::: panels/background/Makefile.am @@ -4,3 @@ -uidir = $(pkgdatadir)/ui/background -dist_ui_DATA = \ - background.ui Where is background.ui added to the dist? @@ +52,3 @@ endif +resource_files = $(shell glib-compile-resources --generate-dependencies $(srcdir)/background.gresource.xml) Can you add a macro for all this which would use $(cappletname)?
Review of attachment 232763 [details] [review]: Looks good.
Review of attachment 232762 [details] [review]: ++
Review of attachment 232741 [details] [review]: ::: panels/background/Makefile.am @@ -4,3 @@ -uidir = $(pkgdatadir)/ui/background -dist_ui_DATA = \ - background.ui Never mind that bit.
Review of attachment 232761 [details] [review]: ++
Review of attachment 232760 [details] [review]: ++
Created attachment 232765 [details] [review] common: use a GResource for GtkBuilder UI definition
Created attachment 232766 [details] [review] shell: use a GResource for GtkBuilder UI definition
Created attachment 232767 [details] [review] user-accounts: remove unused icons These are not used anywhere, so don't install them and remove them from version control.
Created attachment 232768 [details] [review] user-accounts: don't install SVG icons We only use the PNGs in the panel. Keep the SVGs under version control, as they're used to generate the PNGs.
Created attachment 232769 [details] [review] user-accounts: use a GResource for GtkBuilder UI definition and icons
Review of attachment 232767 [details] [review]: ++
Review of attachment 232768 [details] [review]: ++
Attachment 232760 [details] pushed as 8ae20f4 - info: remove unused code Attachment 232761 [details] pushed as df3793d - keyboard: remove unused code Attachment 232762 [details] pushed as 77a26f9 - mouse: remove unused code Attachment 232763 [details] pushed as 9ae15e6 - screen: remove unused code Attachment 232767 [details] pushed as 3637447 - user-accounts: remove unused icons Attachment 232768 [details] pushed as ce54652 - user-accounts: don't install SVG icons
The power panel patch didn't apply cleanly. Attachment 232741 [details] pushed as e30613e - background: use a GResource for GtkBuilder UI definition Attachment 232742 [details] pushed as ddf9d29 - bluetooth: use a GResource for GtkBuilder UI definition Attachment 232743 [details] pushed as bd7e87b - color: use a GResource for GtkBuilder UI definition Attachment 232744 [details] pushed as d2ce735 - datetime: use a GResource for GtkBuilder UI definition and icons Attachment 232745 [details] pushed as b757189 - display: use a GResource for GtkBuilder UI definition Attachment 232746 [details] pushed as 214b514 - info: use a GResource for GtkBuilder UI definition Attachment 232747 [details] pushed as 3b98a73 - keyboard: use a GResource for GtkBuilder UI definition Attachment 232748 [details] pushed as db5aba7 - mouse: use a GResource for GtkBuilder UI definition and icons Attachment 232749 [details] pushed as 57de0ab - network: use a GResource for GtkBuilder UI definition Attachment 232750 [details] pushed as 5975b17 - notifications: use a GResource for GtkBuilder UI definition Attachment 232751 [details] pushed as 0653773 - online-accounts: use a GResource for GtkBuilder UI definition Attachment 232753 [details] pushed as 3064425 - printers: use a GResource for GtkBuilder UI definition Attachment 232754 [details] pushed as 6f48e0f - privacy: use a GResource for GtkBuilder UI definition Attachment 232755 [details] pushed as 887c3ae - region: use a GResource for GtkBuilder UI definition Attachment 232756 [details] pushed as b6b77de - screen: use a GResource for GtkBuilder UI definition Attachment 232757 [details] pushed as 28b6974 - search: use a GResource for GtkBuilder UI definition Attachment 232758 [details] pushed as f7ae09c - universal-access: use a GResource for GtkBuilder UI definition Attachment 232759 [details] pushed as 82f8c13 - wacom: use a GResource for GtkBuilder UI definition and icons Attachment 232765 [details] pushed as ce1e2ed - common: use a GResource for GtkBuilder UI definition Attachment 232769 [details] pushed as eb573a7 - user-accounts: use a GResource for GtkBuilder UI definition and icons
Fixed to apply to master. Attachment 232752 [details] pushed as 645778e - power: use a GResource for GtkBuilder UI definition