GNOME Bugzilla – Bug 690837
test for GBytes.compare must match definition
Last modified: 2012-12-30 10:35:33 UTC
Created attachment 232352 [details] [review] fix test memcmp() as underlaying function for the GBytes.compare method can return other values than the "expected" -1, 0 and 1. The result is defined as equal to, less than or greater than zero. The result for the compare() method in glib's GBytes is defined in the same way. a test failure from s390/s390x architecture in Fedora 19 FAIL: test_compare (test_gi.TestGBytes) ---------------------------------------------------------------------- Traceback (most recent call last):
+ Trace 231322
self.assertEqual(-1, b.compare(a1))
Thank you! I modified the patch to use the richer unittest comparison functions: http://git.gnome.org/browse/pygobject/commit/?id=692c80e11a05e2fb0515580acb22fd6fe65cede1