After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690317 - Make the theme-viewer respect typical viewing contents
Make the theme-viewer respect typical viewing contents
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-12-16 23:34 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-01-11 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme: Make meta_frame_draw_theme take a GtkStyleContext instead of a widget (8.33 KB, patch)
2012-12-16 23:34 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme-viewer: use the same GtkStyleContext as mutter usually renders (8.88 KB, patch)
2012-12-16 23:34 UTC, Jasper St. Pierre (not reading bugmail) 		needs-work Details | Review
theme-viewer: use the same GtkStyleContext as mutter usually renders (10.78 KB, patch)
2013-01-09 19:05 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme: Fix a memory leak (769 bytes, patch)
2013-01-10 21:19 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review
theme: Add the .background style class back to frames (1.05 KB, patch)
2013-01-10 21:20 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2012-12-16 23:34:18 UTC 
This was noted by Company on IRC, that the selectors for actual
frame drawing and theme-viewer are different.
Comment 1 Jasper St. Pierre (not reading bugmail) 2012-12-16 23:34:20 UTC 
Created attachment 231683 [details] [review]
theme: Make meta_frame_draw_theme take a GtkStyleContext instead of a widget

The style context of the widget is rarely what we want. We won't
fix this to be a MetaFrames style context yet; this just changes
the internal API.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-12-16 23:34:22 UTC 
Created attachment 231684 [details] [review]
theme-viewer: use the same GtkStyleContext as mutter usually renders
Comment 3 Owen Taylor 2013-01-09 16:01:41 UTC 
Review of attachment 231683 [details] [review]:

OK
Comment 4 Owen Taylor 2013-01-09 16:07:40 UTC 
Review of attachment 231684 [details] [review]:

This all look looks fine to me, except that the theme viewer is still using gtk_widget_get_style_context (widget) rather than the style context that it is now creating. Can you figure out some way to test the patch?
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-01-09 19:05:40 UTC 
Created attachment 233096 [details] [review]
theme-viewer: use the same GtkStyleContext as mutter usually renders

Hm, I thought I completed this patch set, but I guess not. Thanks for spotting!
Comment 6 Jasper St. Pierre (not reading bugmail) 2013-01-09 19:06:44 UTC 
Comment on attachment 231683 [details] [review]
theme: Make meta_frame_draw_theme take a GtkStyleContext instead of a widget

Attachment 231683 [details] pushed as 22a3126 - theme: Make meta_frame_draw_theme take a GtkStyleContext instead of a widget
Comment 7 Owen Taylor 2013-01-09 19:22:52 UTC 
Review of attachment 233096 [details] [review]:

Looks good
Comment 8 Jasper St. Pierre (not reading bugmail) 2013-01-09 19:36:16 UTC 
Attachment 233096 [details] pushed as 5c33b0d - theme-viewer: use the same GtkStyleContext as mutter usually renders
Comment 9 Jasper St. Pierre (not reading bugmail) 2013-01-10 21:19:59 UTC 
Created attachment 233177 [details] [review]
theme: Fix a memory leak

Commit 5c33b0d tried to copy/paste the code that constructed
classes, but for some reason didn't copy the theme name.
Comment 10 Jasper St. Pierre (not reading bugmail) 2013-01-10 21:20:01 UTC 
Created attachment 233178 [details] [review]
theme: Add the .background style class back to frames

GtkWindow added the BACKGROUND style class to all windows, which the
CSS file selects on to set a background color for all windows. Without
this, the background color becomes undefined, and thus window frames
look like they have "glitchy" graphics.
Comment 11 Cosimo Cecchi 2013-01-10 23:55:11 UTC 
Reopening
Comment 12 Florian Müllner 2013-01-11 13:25:04 UTC 
Review of attachment 233177 [details] [review]:

Yup
Comment 13 Florian Müllner 2013-01-11 13:25:43 UTC 
Review of attachment 233178 [details] [review]:

wfm
Comment 14 Jasper St. Pierre (not reading bugmail) 2013-01-11 17:58:35 UTC 
Attachment 233177 [details] pushed as 9b34545 - theme: Fix a memory leak
Attachment 233178 [details] pushed as 47be4fd - theme: Add the .background style class back to frames