After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 690255 - Try to avoid small or low resolution thumbnails
Try to avoid small or low resolution thumbnails
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
3.10
: 720610 777866 (view as bug list)
Depends on: 779135
Blocks: 763329
 
 
Reported: 2012-12-15 13:20 UTC by Bastien Nocera
Modified: 2018-01-25 21:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (426.07 KB, image/png)
2012-12-15 13:20 UTC, Bastien Nocera
  Details
Add an out-of-process custom thumbnailer (36.26 KB, patch)
2017-02-14 16:43 UTC, Debarshi Ray
none Details | Review
Add PhotosThumbnailFactory (20.82 KB, patch)
2017-02-14 16:45 UTC, Debarshi Ray
committed Details | Review
Add an out-of-process custom thumbnailer (36.24 KB, patch)
2017-02-14 17:58 UTC, Debarshi Ray
committed Details | Review
Instantiate ThumbnailFactory right after MainWindow is created (1.94 KB, patch)
2017-02-14 17:59 UTC, Debarshi Ray
committed Details | Review
Switch to our own thumbnailing infrastructure (13.48 KB, patch)
2017-02-14 17:59 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Use the correct typecast (994 bytes, patch)
2017-02-21 16:16 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Thumbnails should never be bigger than the source images (3.56 KB, patch)
2017-02-21 19:09 UTC, Debarshi Ray
committed Details | Review
thumbnail-factory: Remove redundant if branch (7.75 KB, patch)
2017-02-23 08:49 UTC, Debarshi Ray
committed Details | Review
pixbuf: Fix typo (1016 bytes, patch)
2017-02-23 08:49 UTC, Debarshi Ray
committed Details | Review
build: Bump minimum GEGL version to 0.3.14 (790 bytes, patch)
2017-02-27 21:55 UTC, Debarshi Ray
committed Details | Review
Split the GEGL-related resources into a separate GResource (5.40 KB, patch)
2017-02-27 23:50 UTC, Debarshi Ray
committed Details | Review
thumbnailer: Register the GEGL-related resources (2.27 KB, patch)
2017-02-27 23:51 UTC, Debarshi Ray
committed Details | Review
thumbnail-factory: Remove still-born support for preview GIcons (5.33 KB, patch)
2018-01-25 21:49 UTC, Debarshi Ray
committed Details | Review

Description Bastien Nocera 2012-12-15 13:20:30 UTC
Created attachment 231620 [details]
screenshot

They look like they're upscaled from the small thumbnails in nautilus. They could really be regenerated.
Comment 1 Debarshi Ray 2012-12-15 15:08:04 UTC
This is related to bug 686895

I am beginning to wonder whether we should have gone for a separate attribute for forcing bigger thumbnails. I had a patch for that before I noticed that bug. Not sure. What do you think?
Comment 2 Bastien Nocera 2012-12-15 20:24:21 UTC
Bigger thumbnails would be a good start, otherwise, just generating your own wouldn't be so bad, as long as you do this carefully.
Comment 3 Andreas Nilsson 2013-12-18 12:48:54 UTC
*** Bug 720610 has been marked as a duplicate of this bug. ***
Comment 4 Debarshi Ray 2014-11-21 15:17:54 UTC
These days (since bug 686851) nautilus creates larger thumbnails even if they are actually shown at a smaller size. So this is only an issue for users who have updated from older releases.

I have proposed a patch in bug 686895 to let applications look specifically for large thumbnails instead of silently falling back to smaller sizes.
Comment 5 Debarshi Ray 2017-02-14 16:43:42 UTC
Created attachment 345741 [details] [review]
Add an out-of-process custom thumbnailer
Comment 6 Debarshi Ray 2017-02-14 16:45:27 UTC
Created attachment 345742 [details] [review]
Add PhotosThumbnailFactory
Comment 7 Debarshi Ray 2017-02-14 17:58:47 UTC
Created attachment 345745 [details] [review]
Add an out-of-process custom thumbnailer
Comment 8 Debarshi Ray 2017-02-14 17:59:04 UTC
Created attachment 345746 [details] [review]
Instantiate ThumbnailFactory right after MainWindow is created
Comment 9 Debarshi Ray 2017-02-14 17:59:24 UTC
Created attachment 345747 [details] [review]
Switch to our own thumbnailing infrastructure
Comment 10 Debarshi Ray 2017-02-14 18:10:50 UTC
As mentioned in commit e62947cd9c7a and attachment 345745 [details] [review], there is a bug where some files, particularly JPEGs exported from Darktable, have strange diagonal distortions and are in monochrome. I can't see any obvious difference between our code and the desktop-wide GdkPixbuf thumbnailer.

It will need further debugging, but since it's time for the 3.23.90 release and we have half a dozen thumbnailing related bugs open, I am going to close this. I'll repurpose some other bug for the follow-up fixes.

Please re-open or leave a comment or file another bug if you spot further problems.
Comment 11 Debarshi Ray 2017-02-21 16:16:58 UTC
Created attachment 346371 [details] [review]
thumbnailer: Use the correct typecast

Found a typo.
Comment 12 Debarshi Ray 2017-02-21 19:09:04 UTC
Created attachment 346388 [details] [review]
thumbnailer: Thumbnails should never be bigger than the source images
Comment 13 Debarshi Ray 2017-02-23 08:49:15 UTC
Created attachment 346536 [details] [review]
thumbnail-factory: Remove redundant if branch
Comment 14 Debarshi Ray 2017-02-23 08:49:30 UTC
Created attachment 346537 [details] [review]
pixbuf: Fix typo
Comment 15 Debarshi Ray 2017-02-23 14:54:41 UTC
(In reply to Debarshi Ray from comment #10)
> As mentioned in commit e62947cd9c7a and attachment 345745 [details] [review]
> [review], there is a bug where some files, particularly JPEGs exported from
> Darktable, have strange diagonal distortions and are in monochrome. I can't
> see any obvious difference between our code and the desktop-wide GdkPixbuf
> thumbnailer.

That's a bug in GEGL's GdkPixbuf source. See bug 779135. If we don't have a GEGL release with that fix in time for GNOME 3.24, we will carry our own GdkPixbuf source as a workaround.
Comment 16 Debarshi Ray 2017-02-23 15:05:18 UTC
*** Bug 777866 has been marked as a duplicate of this bug. ***
Comment 17 Debarshi Ray 2017-02-27 21:55:34 UTC
Created attachment 346871 [details] [review]
build: Bump minimum GEGL version to 0.3.14
Comment 18 Debarshi Ray 2017-02-27 23:50:59 UTC
Created attachment 346874 [details] [review]
Split the GEGL-related resources into a separate GResource
Comment 19 Debarshi Ray 2017-02-27 23:51:18 UTC
Created attachment 346875 [details] [review]
thumbnailer: Register the GEGL-related resources
Comment 20 Debarshi Ray 2018-01-25 21:49:05 UTC
Created attachment 367442 [details] [review]
thumbnail-factory: Remove still-born support for preview GIcons