After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689358 - Tweak the window buttons based on the mode
Tweak the window buttons based on the mode
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks: 685744
 
 
Reported: 2012-11-30 16:38 UTC by Debarshi Ray
Modified: 2012-12-02 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Choose the schema for window buttons tweak based on the session mode (3.03 KB, patch)
2012-11-30 16:56 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2012-11-30 16:38:51 UTC
The proposed replaced for the fallback session will run gnome-shell in a different mode. It will use a tiny extension to add the minimize (and maximize?) buttons to the titlebar by default (bug 689275). Therefore the ShowWindowButtons tweak should differentiate between the vanilla GNOME Shell mode and the fallback replacement mode (which is yet to be named).

An org.gnome.Shell.Mode property was added for this: bug 689300.
Comment 1 Debarshi Ray 2012-11-30 16:56:27 UTC
Created attachment 230303 [details] [review]
Choose the schema for window buttons tweak based on the session mode

In addition to the vanilla GNOME Shell modes, it will now have a
fallback replacement mode, which uses a different schema for the
button-layout key. Choose the schema depending on the value of the
org.gnome.Shell.Mode property.
Comment 2 Debarshi Ray 2012-11-30 16:59:49 UTC
Currently I am reading the mode only once, so if someone restarts gnome-shell manually in a different mode then it will not be detected unless the tweak-tool is restarted. This is what we have been doing for the version, so I kept it simple and did the same.
Comment 3 John Stowers 2012-12-02 13:49:51 UTC
Attachment 230303 [details] pushed as f2d8f43 - Choose the schema for window buttons tweak based on the session mode