After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687065 - InstallableOptions is not filtered in cups backend
InstallableOptions is not filtered in cups backend
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.6.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-10-28 21:19 UTC by Benjamin Berg
Modified: 2012-11-29 09:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix the issue (870 bytes, patch)
2012-10-28 21:21 UTC, Benjamin Berg 		accepted-commit_now Details | Review

Description Benjamin Berg 2012-10-28 21:19:52 UTC 
Since some time GTK+ is showing the "InstallableOptions" group for me. My guess is that this is caused by the changes in bug #674326, which seem to have changed what is stored in the ppd_group_t struct slightly.

Now the "text" contains the human readable version, which cannot be used for comparison. Instead the groups "name" should be used. The attach patch changes this, and with it the installable options are not appearing anymore.
Comment 1 Benjamin Berg 2012-10-28 21:21:55 UTC 
Created attachment 227481 [details] [review]
patch to fix the issue
Comment 2 Matthias Clasen 2012-10-29 01:20:00 UTC 
Review of attachment 227481 [details] [review]:

Looks right to me. I'll ask Marek to confirm
Comment 3 Benjamin Berg 2012-11-26 14:41:05 UTC 
Ping! (And putting Marek on the CC'list in case this fell trough the cracks.)
Comment 4 Marek Kašík 2012-11-26 15:29:41 UTC 
I'll look at it tomorrow.
Comment 5 Marek Kašík 2012-11-27 13:26:11 UTC 
Comment on attachment 227481 [details] [review]
patch to fix the issue

Hi Benjamin,

thank you for catching this. This is a regression caused by this commit:

http://git.gnome.org/browse/gtk+/commit/?h=gtk-3-4&id=122e12bc5f07aa6bb5ee101260f48b85d26833ed (gtk-3-4)

http://git.gnome.org/browse/gtk+/commit/?id=46385aff0312ac9680f30cfb2b994f3a423d7130 (gtk-3-6 and master)

Push the patch to gtk-3-4, gtk-3-6 and master please.

Thank you

Marek
Comment 6 Benjamin Berg 2012-11-29 09:10:04 UTC 
Thanks for the review and finding the commit that caused it!

I pushed the fix to all three branches.