After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686253 - Forward button remains insensitive most of the time
Forward button remains insensitive most of the time
Product: epiphany
Classification: Core
Component: Interface
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 720261 (view as bug list)
Depends on:
Reported: 2012-10-16 22:54 UTC by Xan Lopez
Modified: 2018-08-03 19:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

ephy-toolbar: Hide the forward button when it isn't possible to go forward (6.70 KB, patch)
2014-01-13 17:21 UTC, Yosef Or Boczko
needs-work Details | Review

Description Xan Lopez 2012-10-16 22:54:03 UTC
In a "normal" browsing session the Forward button will be insensitive most of the time. This seems a bit pointless, and I noticed that for instance Firefox goes ahead and just hides it until it's actually usable. Not sure if it's worth doing the same.
Comment 1 Jakub Steiner 2012-10-18 21:26:30 UTC
I am in favor of doing this if we can nicely transition it in like firefox does. (scaling the adjacent entry while fading it in or somesuch).
Comment 2 Lapo Calamandrei 2012-10-18 23:28:23 UTC
Yeah with a transition it would be very nice. The same applies to nautilus as well.
Comment 3 William Jon McCann 2013-12-15 13:09:07 UTC
*** Bug 720261 has been marked as a duplicate of this bug. ***
Comment 4 Yosef Or Boczko 2014-01-13 17:21:46 UTC
Created attachment 266178 [details] [review]
ephy-toolbar: Hide the forward button when it isn't possible to go forward
Comment 5 Michael Catanzaro 2015-09-11 04:04:11 UTC
Review of attachment 266178 [details] [review]:

I don't have a strong opinion on whether we should do this or not; so long as the animation looks good, I'm inclined to accept it. I haven't tested it yet since it needs rebased.

::: src/ephy-toolbar.c
@@ +82,2 @@
 static void
+ephy_toolbar_create_back_forward (EphyToolbar *toolbar)

Let's name this ephy_toolbar_create_back_forward_stack

::: src/ephy-toolbar.h
@@ +60,3 @@
 GtkWidget *ephy_toolbar_get_location_entry (EphyToolbar *toolbar);
+GtkWidget *ephy_toolbar_get_stack_back_forward (EphyToolbar *toolbar);

Eh... I suppose this is OK, but let's at least name it ephy_toolbar_get_back_forward_stack.

I think I would prefer something like this:

void ephy_toolbar_set_can_go_forward (EphyToolbar *toolbar, gboolean);

That is easier to use. But your way has value in that it nicely parallels ephy_toolbar_get_location_entry and ephy_toolbar_get_title_box. Up to you.
Comment 6 GNOME Infrastructure Team 2018-08-03 19:47:33 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: