GNOME Bugzilla – Bug 686253
Forward button remains insensitive most of the time
Last modified: 2018-08-03 19:47:33 UTC
In a "normal" browsing session the Forward button will be insensitive most of the time. This seems a bit pointless, and I noticed that for instance Firefox goes ahead and just hides it until it's actually usable. Not sure if it's worth doing the same.
I am in favor of doing this if we can nicely transition it in like firefox does. (scaling the adjacent entry while fading it in or somesuch).
Yeah with a transition it would be very nice. The same applies to nautilus as well.
*** Bug 720261 has been marked as a duplicate of this bug. ***
Created attachment 266178 [details] [review]
ephy-toolbar: Hide the forward button when it isn't possible to go forward
Review of attachment 266178 [details] [review]:
I don't have a strong opinion on whether we should do this or not; so long as the animation looks good, I'm inclined to accept it. I haven't tested it yet since it needs rebased.
@@ +82,2 @@
+ephy_toolbar_create_back_forward (EphyToolbar *toolbar)
Let's name this ephy_toolbar_create_back_forward_stack
@@ +60,3 @@
GtkWidget *ephy_toolbar_get_location_entry (EphyToolbar *toolbar);
+GtkWidget *ephy_toolbar_get_stack_back_forward (EphyToolbar *toolbar);
Eh... I suppose this is OK, but let's at least name it ephy_toolbar_get_back_forward_stack.
I think I would prefer something like this:
void ephy_toolbar_set_can_go_forward (EphyToolbar *toolbar, gboolean);
That is easier to use. But your way has value in that it nicely parallels ephy_toolbar_get_location_entry and ephy_toolbar_get_title_box. Up to you.
-- GitLab Migration Automatic Message --
This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/epiphany/issues/180.