After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 684924 - rtspsrc: flush connection when going to null state
rtspsrc: flush connection when going to null state
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.31
Other Linux
: Normal normal
: 1.0.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-09-27 01:29 UTC by Aleix Conchillo Flaqué
Modified: 2013-02-06 12:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flush connection when going to null (920 bytes, patch)
2012-09-27 03:07 UTC, Aleix Conchillo Flaqué 		none Details | Review

Description Aleix Conchillo Flaqué 2012-09-27 01:29:23 UTC 
Connection is not flushed if we are going to NULL state (and calling gst_rtspsrc_stop). This means that if the gstrtspsrc task is in the middle of opening the connection it might get stuck, for example, in gst_rtspsrc_try_send. In this example, gst_rtspsrc_stop will block for 20 seconds waiting for the thread to complete.
Comment 1 Aleix Conchillo Flaqué 2012-09-27 03:07:37 UTC 
Created attachment 225238 [details] [review]
flush connection when going to null
Comment 2 Aleix Conchillo Flaqué 2012-12-10 12:55:42 UTC 
Any comments on this patch?

It has been working successfully for a couple of months now.
Comment 3 Wim Taymans 2013-02-06 12:14:07 UTC 
The _send_cmd() method is supposed to flush the connection when asked to so I moved that logic there.

commit c3337b28d1ee65e7a321157faa00747dcbb19b81
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Wed Feb 6 13:10:33 2013 +0100

    rtspsrc: always flush connection in stop
    
    Use the flush argument in the send_cmd method to force a flush of the
    connection. We only want to flush the connection when stopping so that
    we can stop and join the task.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=684924