GNOME Bugzilla – Bug 682996
Exception when mounting USB mediaplayer (2.5.0 regression)
Last modified: 2012-09-28 10:25:16 UTC
I use a mobile phone as an MP3-player that is mounted like a traditional USB mass storage device. On top of the filesystem I placed a file ".is_audio_player" - this worked fine with Banshee 2.4.1 - it recognized the mediaplayer and showed it as a device. When I plugin the device on Banshee 2.5.0 and mount it, I get the following error: [22 Warn 23:39:20.491] Caught an exception - System.ArgumentNullException: Argument cannot be null. Parameter name: path2 (in `mscorlib') at System.IO.Path.Combine (System.String path1, System.String path2) [0x000be] in /tmp/buildpkgs/mono/mono-2.11.2/mcs/class/corlib/System.IO/Path.cs:126 at Hyena.Paths.Combine (System.String first, System.String[] components) [0x0004e] in /tmp/txz/banshee/banshee-2.5.0/src/Hyena/Hyena/Hyena/Paths.cs:76 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistsPaths () [0x00092] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:251 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistsWritePath () [0x00019] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:266 at Banshee.Dap.MassStorage.MassStorageSource.get_CanSyncPlaylists () [0x00001] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:332 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistTypes () [0x00095] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:307 at Banshee.Dap.MassStorage.MassStorageSource.AddDapProperties () [0x000f5] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:131 at Banshee.Dap.MassStorage.MassStorageSource.DeviceInitialize (IDevice device) [0x0016c] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:105 at Banshee.Dap.DapService.FindDeviceSource (IDevice device) [0x00029] in /tmp/txz/banshee/banshee-2.5.0/src/Dap/Banshee.Dap/Banshee.Dap/DapService.cs:159
The problem persists on 2.5.1 - does no one have any idea? I don't want to stick to 2.4.1 :(
shcmatzler, sorry to hear that, can you provide your .is_audio_player file as an attachment please?
Created attachment 224567 [details] .is_audio_player file Thanks for the quick response. Here it is :)
Can you confirm that the problem is gone when you switch back to 2.4.1?
I just recompiled 2.4.1 with the exact configuration of packages I had used with 2.5.1 to make sure. It works with 2.4.1 - but not with 2.5.x.
Ok, thanks. Can you keep both trees? I'll cook a debug patch for you to apply to both so we figure out what's wrong.
Of course I can. Thanks for your work.
Created attachment 224779 [details] [review] debug patch v1 Can you test this patch? First, apply it to git master (2.5.1) and test with "banshee --debug". If it still doesn't work, paste here the output, and apply it to 2.4.1 too and paste the output as well. Thanks for testing!
Created attachment 224780 [details] [review] debug patch v2 Oops, please disregard previous patch, and follow the same instructions but with this patch. Thanks!
Applied the patch to 2.5.1 - looks like I get the same error as before: ___MediaCapabilities type is Banshee.Dap.MassStorage.MassStorageDevice and has 1 playlistpaths [21 Warn 23:31:40.944] Caught an exception - System.ArgumentNullException: Argument cannot be null. Parameter name: path2 (in `mscorlib') at System.IO.Path.Combine (System.String path1, System.String path2) [0x000be] in /tmp/buildpkgs/mono/mono-2.11.2/mcs/class/corlib/System.IO/Path.cs:126 at Hyena.Paths.Combine (System.String first, System.String[] components) [0x0004e] in /tmp/txz/banshee/banshee-2.5.1/src/Hyena/Hyena/Hyena/Paths.cs:76 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistsPaths () [0x000be] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:253 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistsWritePath () [0x00019] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:268 at Banshee.Dap.MassStorage.MassStorageSource.get_CanSyncPlaylists () [0x00001] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:334 at Banshee.Dap.MassStorage.MassStorageSource.get_PlaylistTypes () [0x00095] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:309 at Banshee.Dap.MassStorage.MassStorageSource.AddDapProperties () [0x000f5] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:131 at Banshee.Dap.MassStorage.MassStorageSource.DeviceInitialize (IDevice device) [0x0016c] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap.MassStorage/Banshee.Dap.MassStorage/MassStorageSource.cs:105 at Banshee.Dap.DapService.FindDeviceSource (IDevice device) [0x00029] in /tmp/txz/banshee/banshee-2.5.1/src/Dap/Banshee.Dap/Banshee.Dap/DapService.cs:159 I will recompile 2.4.1 with the patch and test.
Created attachment 224785 [details] [review] debug patch v3 Thanks! Can you try this other patch? (Do "git reset --hard" to clean your working copy, and apply again.)
It works now! Thank you. I get the following message: _________playlist_path preferred value is <null> [22 Debug 00:05:06.240] Found DAP support (Banshee.Dap.MassStorage.MassStorageSource) for device Omnia Pro 4 and Uuid /devices/pci0000:00/0000:00:1d.7/usb2/2-1/2-1:1.0/host7/target7:0:0/7:0:0:0/block/sdb/sdb1 I couldn't apply your patch to 2.4.1, though. If you need any more info, I'll be glad to help.
Thanks for testing schmatzler! Pushed fix to master: http://git.gnome.org/browse/banshee/commit/?id=b5b29072db9ce8c57fa379599f9523ef129953bd This problem has been fixed in our software repository. The fix will go into the next software release (2.6.0). Thank you for your bug report.
*** Bug 676729 has been marked as a duplicate of this bug. ***