GNOME Bugzilla – Bug 682905
Port to new documentation infrastructure
Last modified: 2012-09-03 23:44:37 UTC
Created attachment 222686 [details] [review] patch Use yelp-tools instead of gnome-doc-utils See https://live.gnome.org/GnomeGoals/NewDocumentationInfrastructure
Review of attachment 222686 [details] [review]: Hi Oliver!! Thanks for providing this patch! I'd like to mention a few things that needs work before this patch can be commited. I applied it and I saw that now accerciser doensn't compile properly, and this is caused for two reasons: +++ b/help/Makefile.am @@ -32,6 +33,6 @@ +HELP_EXTRA = \ + +HELP_LINGUAS = ca cs de el en_GB es fr gl it ja oc pl pt_BR sl sv uk zh_CN You're defining the HELP_EXTRA and putting a "\" assuming that you're going to add some elements to it, but you aren't. So I think this should be removed. +++ b/help/Makefile.am @@ -1,7 +1,8 @@ +@YELP_RULES@ I think you should add @YELP_HELP_RULES@ instead. +++ b/autogen.sh @@ -3,5 +3,14 @@ + +GNOMEDOC=`which yelp-build` +if test -z $GNOMEDOC; then +echo "*** The tools to build the documentation are not found," +- echo " please intall the gnome-doc-utils package ***" ++ echo " please intall the yelp-tool package ***" +exit 1 +fi + We don't want to stop the compilation here since a user can skip the build of the documentation. +++ b/Makefile.am @@ -22,12 +22,10 @@ - --disable-scrollkeeper \ I'm not completely sure if we want to remove this option. Why did you remove it? Thanks again for your help! Cheers, Javi
Created attachment 223319 [details] [review] patchV2
Sorry for my mistakes. The reason I deleted the --disable-scrollkeeper instruction was because scrollkeeper is not used anymore, but I guess it was unnecessary.
Review of attachment 223319 [details] [review]: Thanks Oliver! Looks better now, I did some slightly modifications and I've just pushed to master [1] Cheers, Javi [1]: http://git.gnome.org/browse/accerciser/commit/?id=5541174d79aae7dd8ff04469ccaf0f5ab252d348