After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 682358 - gui: simplify code when open or closing streams
gui: simplify code when open or closing streams
Status: RESOLVED FIXED
Product: ekiga
Classification: Applications
Component: GUI
unspecified
Other All
: Normal normal
: ---
Assigned To: Ekiga maintainers
Ekiga maintainers
Depends on:
Blocks:
 
 
Reported: 2012-08-21 14:00 UTC by Víctor Manuel Jáquez Leal
Modified: 2012-08-21 16:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gui: simplify code when open or closing streams (7.76 KB, patch)
2012-08-21 14:01 UTC, Víctor Manuel Jáquez Leal 		none Details | Review
gui: simplify code when open or closing streams (8.88 KB, patch)
2012-08-21 15:13 UTC, Víctor Manuel Jáquez Leal 		none Details | Review

Description Víctor Manuel Jáquez Leal 2012-08-21 14:00:59 UTC 
ekiga_call_window_channels_menu_update_sensitivity () obsoleted one of its
parameters, but it was still computed before calling the function.
    
This patch simplifies the functions on_stream_opened_cb() and
on_stream_closed_cb() removing dead code and unused variables.
Comment 1 Víctor Manuel Jáquez Leal 2012-08-21 14:01:01 UTC 
Created attachment 222003 [details] [review]
gui: simplify code when open or closing streams

ekiga_call_window_channels_menu_update_sensitivity () obsoleted one of its
parameters, but it was still computed before calling the function.

This patch simplifies the functions on_stream_opened_cb() and
on_stream_closed_cb() removing dead code and unused variables.
Comment 2 Víctor Manuel Jáquez Leal 2012-08-21 15:13:20 UTC 
Created attachment 222029 [details] [review]
gui: simplify code when open or closing streams

ekiga_call_window_channels_menu_update_sensitivity () obsoleted one of its
parameters, but it was still computed before calling the function.

This patch simplifies the functions on_stream_opened_cb() and
on_stream_closed_cb() removing dead code and unused variables.
Comment 3 Eugen Dedu 2012-08-21 16:28:58 UTC 
Committed, thank you!

http://git.gnome.org/browse/ekiga/commit/?id=9f0c1bb57b.