Bug 681890 - Banshee is not using current MPRIS standard
Banshee is not using current MPRIS standard
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Other Extensions
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2012-08-15 01:19 UTC by Kevin Anthony
Modified: 2012-08-15 16:40 UTC (History)
1 user (show)

See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to bring banshee up to mpris 2.2 (815 bytes, patch)
2012-08-15 01:20 UTC, Kevin Anthony 		needs-work Details | Diff | Review
Correct Patch (4.54 KB, patch)
2012-08-15 14:44 UTC, Kevin Anthony 		committed Details | Diff | Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Description Kevin Anthony 2012-08-15 01:19:43 UTC 
The Current MPRIS standard has two new methods, CanSetFullscreen and Fullscreen
 - CanSetFullscreen returns a Bool if banshee can be set into full screen mode
 - Fullscreen Returns True if Banshee is Fullscreened
    it also takes a True/False to Fullscreen/Unfullscreen the player
Comment 1 Kevin Anthony 2012-08-15 01:20:22 UTC 
Created attachment 221212 [details] [review]
Patch to bring banshee up to mpris 2.2
Comment 2 Bertrand Lorentz 2012-08-15 13:04:21 UTC 
Review of attachment 221212 [details] [review]:

Looks like you mixed up your patches, this is a patch for the MPRIS spec ;)
Comment 3 Kevin Anthony 2012-08-15 14:44:52 UTC 
Created attachment 221268 [details] [review]
 Correct Patch

That's very Embarrassing
Comment 4 Bertrand Lorentz 2012-08-15 16:40:18 UTC 
Comment on attachment 221268 [details] [review]
 Correct Patch

Thanks for the patch, I've had this on my todo list for quite a while but never got around to do it.

I've committed it with a few changes, mainly to implement the PropertiesChanged signal for the Fullscreen property. This allows MPRIS client to be notified when Banshee changes to and from fullscreen mode.
Comment 5 Bertrand Lorentz 2012-08-15 16:40:30 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Note You need to log in before you can comment on or make changes to this bug.