GNOME Bugzilla – Bug 681769
Indicate currently-logged-in status as check mark in user list
Last modified: 2012-10-09 08:53:13 UTC
We should indicate the currently logged in status in the user list with a checkmark. As discussed on #gnome-design. The logic is that it's very relevant to management of accounts to see whether the user is logged in. For example when removing an account, or changing passwords etc. To do this we need to remove the checkmark that currently represents the autologin status. See https://live.gnome.org/action/diff/Design/SystemSettings/UserAccounts for more work on how auto-logins would be represented.
Created attachment 221163 [details] [review] user-accounts: Remove the autologin checkmark in the list We want to use the checkmark for indicating the the currently logged in status. Jon suggested we remove this for 3.6 even though we probably won't be adding the indication of currently logged in status right away.
I'm not entirely sure that a checkmark is the best way to indicate this however. In other places we use a "glow" to indicate the thing is "on". Jakub, what do you think?
Created attachment 221170 [details] Maybe just a green dot? The glow relies on on a dark background list.
Works for me.
Review of attachment 221163 [details] [review]: Needs some changes to match the mockup.
(In reply to comment #5) > Review of attachment 221163 [details] [review]: > > Needs some changes to match the mockup. I am working on it.
Created attachment 222784 [details] [review] add logged in status identification Patch adds status identification according aday mockup.
Created attachment 222785 [details] screenshot with new status identificator
Some thoughts brought up on #gnome-design: <aday> mccann, jimmac, https://bugzilla.gnome.org/attachment.cgi?id=222785 <aday> jimmac, might need some guidance on the green spot :) <hbons> aday: what does it mean? <aday> hbons, logged in one idea: <hbons> ok, just use some text perhaps? :) <hbons> second line "aday | Logged in" or something <aday> the first string could get long in some cases; we'd need to resolve that <aday> tony-stark@stark-industries.com | Logged in <hbons> it could look weird if you right align that though other idea: <ryanlerch> are there going to be any other categories in that left list other than "My Account" and "Other Accounts", would it be worth removing that and grouping by logged in and not logged in? One thought about increasing the fidelity of the circle: <jimmac> oholy, can you try a 2px white stroke? <jimmac> oholy, let me doodle for a sec <jimmac> http://jimmac.musichall.cz/stuff/gnome3/logged-in.png
Also see bug 681753 and https://live.gnome.org/Design/Proposals/UserIdentities?action=AttachFile&do=get&target=user-accounts-enterprise.png where the idea of sectioning based on enterprise realm is brought up.
Talking with jimmac, the idea of section based on enterprise realm has been dismissed, since it's pretty likely if you have an enterprise realm, that you logged in with it as your primary account.
Created attachment 222934 [details] [review] add logged in status identification There is logged in status mark according jimmac doodle, or should I use some system icon instead, or should I remove the green mark completely?
Created attachment 222935 [details] screenshot with new status identificator
Created attachment 222946 [details] [review] add logged in status identification Attached patch is slightly changed after discussion on #gnome-design.
Created attachment 222947 [details] screenshot with new status identificator
Looks great now :)
Review of attachment 222946 [details] [review]: ::: panels/user-accounts/um-user.c @@ +445,3 @@ + /* Draw pattern */ + cairo_rectangle (cr, 0, 0, width, height); + pattern = cairo_pattern_create_radial (width - 9.5, height - 10, 0, width - 8.5, height - 7.5, 7.7); What happens if the pixbug is tiny? ::: panels/user-accounts/um-user.h @@ +98,3 @@ GdkPixbuf *um_user_render_icon (UmUser *user, gboolean framed, + gboolean with_logged_status, Can you replace both framed and with_logged_status with an enum with a bitfield? It would make adding any more changes to the rendering easier.
(In reply to comment #17) > Review of attachment 222946 [details] [review]: > > ::: panels/user-accounts/um-user.c > @@ +445,3 @@ > + /* Draw pattern */ > + cairo_rectangle (cr, 0, 0, width, height); > + pattern = cairo_pattern_create_radial (width - 9.5, height - 10, 0, > width - 8.5, height - 7.5, 7.7); > > What happens if the pixbug is tiny? You are right, it doesn't work correctly for different sized icons, on the other hand icons have hardcoded size 48. However I'll fix it. > ::: panels/user-accounts/um-user.h > @@ +98,3 @@ > GdkPixbuf *um_user_render_icon (UmUser *user, > gboolean framed, > + gboolean with_logged_status, > > Can you replace both framed and with_logged_status with an enum with a > bitfield? It would make adding any more changes to the rendering easier. Ok, I'll replace it using bitfields.
Created attachment 223995 [details] [review] add logged in status identification Bitfield is added for style of the icon. Dynamic computing position and size of status mark is inaccurate and result looks ugly, so I limited the input minimal size only. Is it enought?
Created attachment 224090 [details] [review] add logged in status identification small change of previous patch due to memory leak possibility
Review of attachment 224090 [details] [review]: ::: panels/user-accounts/um-password-dialog.c @@ +647,3 @@ um->user = g_object_ref (user); + pixbuf = um_user_render_icon (user, 0, 48); Use a flag here instead of 0. ::: panels/user-accounts/um-user.c @@ +524,3 @@ } + if (pixbuf != NULL && style & UM_ICON_STYLE_STATUS && um_user_is_logged_in (user)) { brackets around: style & UM_ICON_STYLE_STATUS ::: panels/user-accounts/um-user.h @@ +47,3 @@ +typedef enum { + UM_ICON_STYLE_FRAME = 1 << 0, UM_ICON_STYLE_NONE = 0,
Created attachment 224196 [details] [review] add logged in status identification There is fixed patch according the review.
Review of attachment 224196 [details] [review]: All comments were addressed, lets get this in.
When I see a green circle superimposed on a user's avatar, I think "user logged in and available in chat". On the other hand, it looks like Contacts & Empathy are using a green speech bubble so it's not quite the same. Without text that says "logged in" or similar, I think many people will misinterpret the UI at first glance.
Wondering if non-available people should have a red circle then. Showing nothing implies "unknown status" to me.
(In reply to comment #25) > Wondering if non-available people should have a red circle then. > Showing nothing implies "unknown status" to me. There is a benefit in having nothing - it makes the two items very distinguishable from one another. Relying on color coding would be bad, but even creating a different shape is not improving the contrast between the two.
Sure it's more distinguishable, but the meaning of the green icon and of not having a green icon still is not necessarily more discoverable just because of that.
(In reply to comment #23) > Review of attachment 224196 [details] [review]: > > All comments were addressed, lets get this in. It wasn't scheduled for 3.6. At least, I'd like to see whether freeze breaks were requested for it.
(In reply to comment #28) > (In reply to comment #23) > > Review of attachment 224196 [details] [review] [details]: > > > > All comments were addressed, lets get this in. > > It wasn't scheduled for 3.6. At least, I'd like to see whether freeze breaks > were requested for it. I requested one over the weekend, but too late now. Nevermind