GNOME Bugzilla – Bug 679723
connection editor: make vpn import available from create dialog
Last modified: 2012-08-07 19:18:13 UTC
Created attachment 218497 [details] [review] patch Here is a somewhat quick-and-dirty patch to implement https://github.com/gnome-design-team/gnome-mockups/blob/14f952117eeb60aeccba8608c5420263d86370a0/system-settings/network/aday/png/vpn.png
Dan gave his ok in principle to the idea - now we just need to turn this into a production-quality patch.
In the mockup linked above, the fact that "Cisco Compatible VPN (vpnc)" is visible suggests that the "Import" button will only let you import a vpnc config, but that's not the intention, right? The combobox is just irrelevant when you click "Import"? (As part of the nm-connection-editor reorg for adding infiniband, wimax, and bonding support, I'd made a similar change to the dialog, except that instead of having an "Import" button, there was an "Import a saved VPN configuration..." option at the end of the pop-up menu (after a separator).)
(In reply to comment #2) ... > (As part of the nm-connection-editor reorg for adding infiniband, wimax, and > bonding support, I'd made a similar change to the dialog, except that instead > of having an "Import" button, there was an "Import a saved VPN > configuration..." option at the end of the pop-up menu (after a separator).) Makes sense. Updated mockup: https://github.com/gnome-design-team/gnome-mockups/raw/master/system-settings/network/aday/png/vpn.png I've also added export to the VPN settings dialog: https://github.com/gnome-design-team/gnome-mockups/raw/master/system-settings/network/aday/png/vpn-settings.png
Created attachment 218715 [details] [review] Fix some leaks g_object_get() and gtk_tree_model_get() copy/ref the values they return, so make sure to deal with that everywhere. ==== (not really related, but it was on my new-editor branch and the VPN changes slightly depend on it)
Created attachment 218716 [details] [review] connection-editor: update .ui file Re-save nm-connection-editor.ui, "unchanged", in current glade. (To make it clearer what's *actually* changing in future updates.)
Created attachment 218717 [details] [review] connection-editor: move VPN import/export Make VPN Import be an option underneath the other VPN types in the "Add" dialog box, and make VPN Export be a button in the connection editor.
With this patch, the "new vpn" dialog is basically as in the mockup. This also removes the "Import" and "Export" buttons from the VPN connection list (which was what I originally wrote this patch for; we can't merge the separate connection types together if the VPN page is different from all the other pages), and moves the Export button into the individual connection editor dialog (see attachment). The bottom left of the connection editor dialog contains the "Available to all users" checkbox in current nm-connection-editor; this patch moves that checkbox up to the top (with "Connect automatically") so that the "Export..." button can go in the bottom left. (This only affects people using nm-connection-editor directly; control-center users wouldn't see either of those dialogs.)
Created attachment 218720 [details] vpn editor dialog
pushed to git now that 0.9.6 is out