After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678996 - Colors: indigo,silver,aqua missing in xpm-color-table.h
Colors: indigo,silver,aqua missing in xpm-color-table.h
Status: RESOLVED FIXED
Product: gdk-pixbuf
Classification: Platform
Component: general
2.26.x
Other Linux
: Normal normal
: ---
Assigned To: gdk-pixbuf-maint
gdk-pixbuf-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-27 18:10 UTC by 7.2k9a4Y3W5c
Modified: 2014-02-05 02:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update color table by value from pango (44.86 KB, patch)
2013-04-06 07:15 UTC, Denis Pauk
none Details | Review

Description 7.2k9a4Y3W5c 2012-06-27 18:10:31 UTC
The colors indigo,silver and aqua are missing from xpm-color-table.h
indigo is defined as an x11 "Extended color keywords" by w3.org.
silver and aqua are defined both as "Basic color Keywords" and "Extended color keywords" by W3.org.

http://www.w3.org/TR/css3-color/#html4

http://www.w3.org/TR/css3-color/#svg-color
Comment 1 Matthias Clasen 2013-03-02 15:28:57 UTC
a patch would be welcome
Comment 2 Denis Pauk 2013-04-06 07:15:57 UTC
Created attachment 240815 [details] [review]
Update color table by value from pango

For update have used values from https://git.gnome.org/browse/pango/log/tools/rgb.txt that have already updated version of SVG/CSS pallete
Comment 3 Andrey Panov 2014-02-05 02:57:33 UTC
(In reply to comment #2)
> Created an attachment (id=240815) [details] [review]
> Update color table by value from pango
> 
> For update have used values from
> https://git.gnome.org/browse/pango/log/tools/rgb.txt that have already updated
> version of SVG/CSS pallete

This patch changed some color name from the traditional X11 color chart to the W3C standard. For example, the "green" color was changed. Read more information here: http://en.wikipedia.org/wiki/X11_color_names

It is reasonable to use the X11 colors (e.g. as defined in libXpm/rgbtab.h) for  xpm-color-table.h.