GNOME Bugzilla – Bug 678703
Resolve a relative path in the module file relative to the module file
Last modified: 2018-05-22 13:13:46 UTC
Created attachment 217112 [details] [review] Resolve a relative path in the module file relative to the module file Problem: currently the ".../libpixbufloader-*.so" lines in the module file must be absolute file names. This renders gdk-pixbuf non relocatable. I use this path to build a fully relocatable application. The patch changes gdk-pixbuf to resolve a relative path in the module file relative to the module file itself.
bug 737523 contains similar patches.
Is this still needed now that bug 737523 is fixed?
As far as I can see, bug 737523 does not cover relative file names in in the module file. Therefore my patch is still needed.
Review of attachment 217112 [details] [review]: You'd also need to update this patch to the latest version, and make sure to use git to format the patch, so it contains authoring information, and a short explanation of the problem it solves. ::: gdk-pixbuf-2.22.0/gdk-pixbuf/gdk-pixbuf-io.c.orig @@ +309,3 @@ } +static void You can return an allocated string, rather than passing an in/out parameter. @@ +318,3 @@ + * of the module file. Because module_file is an absolute path, the result will be + * absolute as well. + */ On the line above. @@ +319,3 @@ + * absolute as well. + */ + gchar *tem = *path; "tmp" @@ +322,3 @@ + gchar *dir = g_path_get_dirname (module_file); + *path = g_build_filename (dir, tem, NULL); + g_free(dir); Space before parenthesis.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdk-pixbuf/issues/34.