After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 678439 - crash in event translation
crash in event translation
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: x11
unspecified
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-20 04:04 UTC by Matthias Clasen
Modified: 2012-06-20 14:14 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible fix (1.19 KB, patch)
2012-06-20 04:04 UTC, Matthias Clasen
accepted-commit_now Details | Review
XI2: Avoid a crash in event translation (1.76 KB, patch)
2012-06-20 11:32 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2012-06-20 04:04:11 UTC
I've seen the following crash in gnome-initial-setup when changing screen resolution using xrandr:

  • #0 _clutter_input_device_reset_axes
    at ./clutter-input-device.c line 941
  • #1 clutter_device_manager_xi2_translate_event
    at x11/clutter-device-manager-xi2.c line 736
  • #2 clutter_backend_real_translate_event
    at ./clutter-backend.c line 569
  • #3 clutter_x11_handle_event
    at x11/clutter-event-x11.c line 198
  • #4 gtk_clutter_filter_func
    at ./gtk-clutter-embed.c line 217
  • #5 gdk_event_apply_filters
    at gdkeventsource.c line 81

Comment 1 Matthias Clasen 2012-06-20 04:04:45 UTC
Created attachment 216778 [details] [review]
possible fix
Comment 2 Emmanuele Bassi (:ebassi) 2012-06-20 07:29:13 UTC
Review of attachment 216778 [details] [review]:

looks good to me
Comment 3 Matthias Clasen 2012-06-20 11:32:26 UTC
The following fix has been pushed:
e3ca877 XI2: Avoid a crash in event translation
Comment 4 Matthias Clasen 2012-06-20 11:32:28 UTC
Created attachment 216819 [details] [review]
XI2: Avoid a crash in event translation

It is possible that we get a DeviceChanged event for a device
that is not in the hash table yet. E.g. I've seen this when
using xrandr to change screen resolution. Prevent a crash in
this case.

https://bugzilla.gnome.org/review?bug=678439
Comment 5 Christophe Fergeau 2012-06-20 14:14:32 UTC
For the record, I've seen this when unplugging and replugging my USB mouse. It's gone now with git master.