Bug 678069 – [abrt] Crash in _gdata_entry_update_from_e_contact()

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 678069 - [abrt] Crash in _gdata_entry_update_from_e_contact()


Summary:	[abrt] Crash in _gdata_entry_update_from_e_contact()


Status:	RESOLVED FIXED

Product:	evolution-data-server
Classification:	Platform
Component:	Contacts
Version:	3.4.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-addressbook-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:	evolution[google]

Depends on:
Blocks:

Reported:	2012-06-14 07:17 UTC by Milan Crha
Modified:	2012-06-15 13:26 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
eds patch (5.83 KB, patch) 2012-06-15 13:21 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2012-06-14 07:17:59 UTC

Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=831768

[abrt] evolution-data-server-3.4.2-1.fc17: Process /usr/libexec/evolution-addressbook-factory was killed by signal 11 (SIGSEGV)

comment:        Trying to uncheck "favourite" from a contact in Empathy.

libreport version: 2.0.10
abrt_version:   2.0.10
backtrace_rating: 4
cmdline:        /usr/libexec/evolution-addressbook-factory
crash_function: _gdata_entry_update_from_e_contact
executable:     /usr/libexec/evolution-addressbook-factory
kernel:         3.4.0-1.fc17.x86_64
time:           mié 13 jun 2012 19:42:32 CEST

3083	category_id = create_group (backend, category_name, &error);
3084	if (category_id == NULL) {
3085		g_warning ("Error creating group '%s': %s", category_name, error->message);
3086		g_error_free (error);
3087		continue;
3088	}

+ Trace 230365

Thread 1 (Thread 0x7fa9a6048700 (LWP 2364))

#0 _gdata_entry_update_from_e_contact
at e-book-backend-google.c line 3085
#1 e_book_backend_google_modify_contacts
at e-book-backend-google.c line 1901
#2 operation_thread
at e-data-book.c line 173
#3 g_thread_pool_thread_proxy
at gthreadpool.c line 309
#4 g_thread_proxy
at gthread.c line 801
#5 start_thread
at pthread_create.c line 309
#6 clone
at ../sysdeps/unix/sysv/linux/x86_64/clone.S line 115

Comment 1 Milan Crha 2012-06-15 13:21:40 UTC

Created attachment 216515 [details] [review]
eds patch

for evolution-data-server;

This works fine for me, when I try from evolution. I think that the issue here is that get_groups is not called soon enough, or just finished soon enough, when contact modification is invoked through Empathy. This patch ensures system groups being fetched and even when something fails than the same crash will not happen again (checking for 'error' not being NULL).

Comment 2 Milan Crha 2012-06-15 13:26:01 UTC

Created commit a7a0f31 in eds master (3.5.3+)
Created commit d3eeb57 in eds gnome-3-4 (3.4.3+)