After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677955 - Clicking under/above the time slider causes a pause of the slider and the time label
Clicking under/above the time slider causes a pause of the slider and the tim...
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 680821 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-06-12 15:34 UTC by Thomas Lange
Modified: 2012-07-30 10:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to fix this bug report (417 bytes, patch)
2012-06-13 13:44 UTC, Thomas Lange
rejected Details | Review

Description Thomas Lange 2012-06-12 15:34:52 UTC
Description:
Clicking under/above the time slider causes a pause
of the slider and the time label.
This is because clicking on the toolbar also emits button-press/release-events.

How to reproduce:
Click under/above the time slider.

Expected behaviour:
Nothing happens if the area under/above the slider is clicked.

Actual behaviour:
The slider and the time label pause.

Further information:
The audio player audacious had the same problem.
I've fixed it with this commit:
https://github.com/audacious-media-player/audacious-plugins/commit/497a0dceb7b680d6247888e9da9fce775dccc2bf

The solution is to put the slider in an alignment
which has a yscale value of zero.
Comment 1 Jonathan Matthew 2012-06-13 12:29:24 UTC
I am unable to reproduce this.

What version of rhythmbox are you using?
Comment 2 Thomas Lange 2012-06-13 13:44:41 UTC
Created attachment 216279 [details] [review]
Patch to fix this bug report
Comment 3 Thomas Lange 2012-06-13 13:45:02 UTC
The latest one (2.97).
But I think it's dependent on the theme you are using.
It needs to allow dragging the window by clicking on the primary toolbar.
Greybird e.g. doesn't, so try Orion theme.

A working patch is attached.
Comment 4 Thomas Lange 2012-06-26 14:26:18 UTC
Any update? The patch is simple to review... ;)
Comment 5 Jonathan Matthew 2012-06-27 06:48:49 UTC
Review of attachment 216279 [details] [review]:

This doesn't actually fix anything, and it also makes it much harder to click on the slider.
Comment 6 Thomas Lange 2012-06-27 11:22:08 UTC
Of course it fixes something, the reported issue can no more be reproduced...
Are you at least able to reproduce the issue with another theme now?
Comment 7 Jonathan Matthew 2012-06-27 11:25:10 UTC
I can reproduce this with the default theme.  Your patch makes no difference with the default theme (it doesn't make it harder to click on the slider, that was a different bug).
Comment 8 Thomas Lange 2012-06-27 11:31:29 UTC
What do you mean with "default theme"?
Comment 9 Jonathan Matthew 2012-06-28 10:56:38 UTC
The default GNOME theme, adwaita.

Commit be47f2f fixes this.  What was actually happening was that the header though the slider was still being dragged, so it stopped updating.  The header now treats focus-out events as breaking the drag and everything works properly.
Comment 10 Thomas Lange 2012-06-28 13:16:42 UTC
Thanks for the fix.
I've noticed that my single-line-patch only works 100% correctly
if you don't use GTK+ 3.5.
With 3.5 you can click on the focus of the scale which overlaps with the toolbar
and there you have the same issue again.
Comment 11 Jonathan Matthew 2012-07-30 10:19:27 UTC
*** Bug 680821 has been marked as a duplicate of this bug. ***