After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 677407 - Fix introspection annotations
Fix introspection annotations
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2012-06-04 18:36 UTC by Pavel Holejsovsky
Modified: 2012-06-04 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix annotation for pango_layout_move_cursor_visually() (1.83 KB, patch)
2012-06-04 18:36 UTC, Pavel Holejsovsky
committed Details | Review
Annotations: add missing colons after symbol names (4.61 KB, patch)
2012-06-04 18:36 UTC, Pavel Holejsovsky
committed Details | Review
Add missing (element-type) annotations for list arguments (1.69 KB, patch)
2012-06-04 18:36 UTC, Pavel Holejsovsky
committed Details | Review
Fix transfer annotation for pango_font_family_list_faces (1.38 KB, patch)
2012-06-04 18:36 UTC, Pavel Holejsovsky
committed Details | Review

Description Pavel Holejsovsky 2012-06-04 18:36:11 UTC
Some introspection annotations are missing or have incorrect format, detected by recent enough g-ir-scanner.
Comment 1 Pavel Holejsovsky 2012-06-04 18:36:14 UTC
Created attachment 215574 [details] [review]
Fix annotation for pango_layout_move_cursor_visually()
Comment 2 Pavel Holejsovsky 2012-06-04 18:36:16 UTC
Created attachment 215575 [details] [review]
Annotations: add missing colons after symbol names
Comment 3 Pavel Holejsovsky 2012-06-04 18:36:19 UTC
Created attachment 215576 [details] [review]
Add missing (element-type) annotations for list arguments
Comment 4 Pavel Holejsovsky 2012-06-04 18:36:21 UTC
Created attachment 215577 [details] [review]
Fix transfer annotation for pango_font_family_list_faces

The documentation says 'This array should be freed with g_free() when
it is no longer needed', which really translates to (transfer
container) in introspection annotation jargon.
Comment 5 Pavel Holejsovsky 2012-06-04 19:02:00 UTC
Attachment 215574 [details] pushed as e51e452 - Fix annotation for pango_layout_move_cursor_visually()
Attachment 215575 [details] pushed as 1706bda - Annotations: add missing colons after symbol names
Attachment 215576 [details] pushed as 7b79cef - Add missing (element-type) annotations for list arguments
Attachment 215577 [details] pushed as c6f0bfe - Fix transfer annotation for pango_font_family_list_faces