GNOME Bugzilla – Bug 673913
gmacros: Try to use the standard __func__ first in G_STRFUNC
Last modified: 2018-05-24 13:59:40 UTC
__func__ is part of the C99 standard. __FUNCTION__ is another name for __func__. Older versions of GCC recognize only this name. However, it is not standardized. For maximum portability, Its recommended to use __func__. See http://gcc.gnu.org/onlinedocs/gcc/Function-Names.html
Created attachment 211838 [details] [review] gmacros: Try to use the standard __func__ first in G_STRFUNC
Created attachment 211841 [details] [review] gmacros: Try to use the standard __func__ first in G_STRFUNC.v2
Comment on attachment 211841 [details] [review] gmacros: Try to use the standard __func__ first in G_STRFUNC.v2 >+# define __func__ __func__ that seems a little goofy Why not #ifdef __func__ # define G_STRFUNC ((const char*) (__func__)) ?
Created attachment 266153 [details] [review] gmacros: Try to use the standard __func__ first in G_STRFUNC.v3
Comment on attachment 266153 [details] [review] gmacros: Try to use the standard __func__ first in G_STRFUNC.v3 OK to commit as long as you have run "make check" and verified that this doesn't break any tests (eg because of g_test_expect_message()) >Subject: [PATCH] cros: Try to use the standard __func__ first in G_STRFUNC not sure what stage it happened in, but the subject is slightly mangled there ("cros" instead of "gmacros"). Make sure it doesn't get committed that way.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/535.