GNOME Bugzilla – Bug 672577
Extra providers for lyrics and use lyrics plugin for the ContextPane lyrics' tab
Last modified: 2018-05-24 17:23:07 UTC
Created attachment 210267 [details] fixes for lyrics and contextpane plugins I attach some modifications I made over the lyrics plugin, adding some new sources/retrievers for lyrics, since the default ones are all outdated (Terra stoped working like 2 weeks ago). Also, I attach a little modification in the ContextPane plugin so it uses the lyrics provided by the lyrics' plugin, instead of it's own procedure (which doesn't work anymore).
Please attach your changes as a patch, preferably in git format-patch form, but any kind of unified diff is okay.
Created attachment 210296 [details] [review] git format-patch Here it goes, hope it helps.
Created attachment 212072 [details] [review] git format-patch for v2.96 Finally made the transition to the 2.x version. Last patch was for 1.3x version btw. What is included in this patch: - Added some lyrics providers. - Integrated the lyrics plugins with the context plugins, added the dependency on the plugin definition. - Added unicode handling on both plugins, because they would fail when trying to make http request or when trying to render lyrics with non-ascii chars. Hope it helps.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1169.