After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672577 - Extra providers for lyrics and use lyrics plugin for the ContextPane lyrics' tab
Extra providers for lyrics and use lyrics plugin for the ContextPane lyrics' tab
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Plugins (other)
0.13.x
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-21 17:48 UTC by Agustin Carrasco
Modified: 2018-05-24 17:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fixes for lyrics and contextpane plugins (4.07 KB, application/x-xz)
2012-03-21 17:48 UTC, Agustin Carrasco
  Details
git format-patch (27.70 KB, patch)
2012-03-21 23:19 UTC, Agustin Carrasco
none Details | Review
git format-patch for v2.96 (34.97 KB, patch)
2012-04-15 05:31 UTC, Agustin Carrasco
none Details | Review

Description Agustin Carrasco 2012-03-21 17:48:26 UTC
Created attachment 210267 [details]
fixes for lyrics and contextpane plugins

I attach some modifications I made over the lyrics plugin, adding some new sources/retrievers for lyrics, since the default ones are all outdated (Terra stoped working like 2 weeks ago). 
Also, I attach a little modification in the ContextPane plugin so it uses the lyrics provided by the lyrics' plugin, instead of it's own procedure (which doesn't work anymore).
Comment 1 Jonathan Matthew 2012-03-21 22:01:28 UTC
Please attach your changes as a patch, preferably in git format-patch form, but any kind of unified diff is okay.
Comment 2 Agustin Carrasco 2012-03-21 23:19:36 UTC
Created attachment 210296 [details] [review]
git format-patch

Here it goes, hope it helps.
Comment 3 Agustin Carrasco 2012-04-15 05:31:04 UTC
Created attachment 212072 [details] [review]
git format-patch for v2.96

Finally made the transition to the 2.x version. Last patch was for 1.3x version btw.

What is included in this patch:
- Added some lyrics providers.
- Integrated the lyrics plugins with the context plugins, added the dependency on the plugin definition.
- Added unicode handling on both plugins, because they would fail when trying to make http request or when trying to render lyrics with non-ascii chars.

Hope it helps.
Comment 4 GNOME Infrastructure Team 2018-05-24 17:23:07 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1169.