GNOME Bugzilla – Bug 672081
Add more default arguments
Last modified: 2012-03-16 19:38:26 UTC
This is to improve the compatibility with PyGTK, and make sense in general. There should probably move into gtk+ proper when gobject-introspection supports default arguments.
Created attachment 209749 [details] [review] Add a default argument to Pango.Context.get_metrics()
Created attachment 209750 [details] [review] Add a default argument to Gtk.TreeView.set_cursor And also make sure that the path is a Gtk.TreePath.
Created attachment 209751 [details] [review] Add a default argument to TreeModelFilter.set_visible_func()
All three looks good to me (thanks!) but some unit test would be nice, especially for the second one that add more logic than plain default values
Comment on attachment 209749 [details] [review] Add a default argument to Pango.Context.get_metrics() First and third look obvious enough. +1 for test-case'ing the second one. Thanks!
Created attachment 209835 [details] [review] Add a default argument to Gtk.TreeView.set_cursor And also make sure that the path is a Gtk.TreePath.
Review of attachment 209835 [details] [review]: looks good to me but... ::: tests/test_overrides.py @@ +1419,3 @@ + view = Gtk.TreeView() + # We can't easily call get_cursor() to make sure this works as + # exepcted as works as we need to realize and focus the column ...since I am really a PITA, there is a typo in the comment :P
Attachment 209751 [details] pushed as a7b08cb - Add a default argument to TreeModelFilter.set_visible_func()