After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671900 - Folks should not suggest linking contacts from telepathy-salut
Folks should not suggest linking contacts from telepathy-salut
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-12 13:38 UTC by Guillaume Desmottes
Modified: 2012-03-26 10:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Discount potential matches between individuals with trust levels of NONE (3.29 KB, patch)
2012-03-24 19:25 UTC, Philip Withnall
committed Details | Review

Description Guillaume Desmottes 2012-03-12 13:38:55 UTC
Link-local personas can't be linked because they are not safe (pretty easy to spoof). But Folks suggest to link those personas regardless.
Comment 1 Philip Withnall 2012-03-24 19:25:31 UTC
Created attachment 210526 [details] [review]
Discount potential matches between individuals with trust levels of NONE

This should fix the problem, although I couldn't test it due to gnome-contacts not working for me at the moment. :-(
Comment 2 Philip Withnall 2012-03-24 19:25:43 UTC
Branch here: https://www.gitorious.org/folks/folks/commits/671900-potential-match-trust
Comment 3 Guillaume Desmottes 2012-03-26 08:22:46 UTC
Review of attachment 210526 [details] [review]:

++
Comment 4 Philip Withnall 2012-03-26 10:37:18 UTC
Comment on attachment 210526 [details] [review]
Discount potential matches between individuals with trust levels of NONE

commit 6e92923a31576058b0064f660d4065ff267fa859
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Mar 24 18:58:58 2012 +0000

    Bug 671900 — Folks should not suggest linking contacts from telepathy-salut
    
    Reject any possibility of a match between two individuals if either of them
    have a trust level of NONE (which can happen if they contain link-local XMPP
    personas, for example).
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=671900

 NEWS                       |    1 +
 folks/potential-match.vala |   33 +++++++++++++++++++++++++++------
 2 files changed, 28 insertions(+), 6 deletions(-)

commit 01bb4e28b7760c105867c885f546d20e70c8e34e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Mar 24 18:56:43 2012 +0000

    core: Make PotentialMatch._inspect_im_addresses() private
    
    It was never meant to be public, and nobody should've been using it.
    Consequently, let's pretend this isn't an API break.

 folks/potential-match.vala |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)