GNOME Bugzilla – Bug 671900
Folks should not suggest linking contacts from telepathy-salut
Last modified: 2012-03-26 10:37:24 UTC
Link-local personas can't be linked because they are not safe (pretty easy to spoof). But Folks suggest to link those personas regardless.
Created attachment 210526 [details] [review] Discount potential matches between individuals with trust levels of NONE This should fix the problem, although I couldn't test it due to gnome-contacts not working for me at the moment. :-(
Branch here: https://www.gitorious.org/folks/folks/commits/671900-potential-match-trust
Review of attachment 210526 [details] [review]: ++
Comment on attachment 210526 [details] [review] Discount potential matches between individuals with trust levels of NONE commit 6e92923a31576058b0064f660d4065ff267fa859 Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sat Mar 24 18:58:58 2012 +0000 Bug 671900 — Folks should not suggest linking contacts from telepathy-salut Reject any possibility of a match between two individuals if either of them have a trust level of NONE (which can happen if they contain link-local XMPP personas, for example). Closes: https://bugzilla.gnome.org/show_bug.cgi?id=671900 NEWS | 1 + folks/potential-match.vala | 33 +++++++++++++++++++++++++++------ 2 files changed, 28 insertions(+), 6 deletions(-) commit 01bb4e28b7760c105867c885f546d20e70c8e34e Author: Philip Withnall <philip@tecnocode.co.uk> Date: Sat Mar 24 18:56:43 2012 +0000 core: Make PotentialMatch._inspect_im_addresses() private It was never meant to be public, and nobody should've been using it. Consequently, let's pretend this isn't an API break. folks/potential-match.vala | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)