After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670327 - Orca doesn't present Categories on the Applications view correctly
Orca doesn't present Categories on the Applications view correctly
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 667432
Blocks:
 
 
Reported: 2012-02-18 01:43 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-03-14 11:44 UTC
See Also:
GNOME target: 3.4
GNOME version: 3.3/3.4


Attachments
Expose StButton:label as accessible name (2.05 KB, patch)
2012-02-18 01:44 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review
Setting MENU-ITEM role for the categories items (1.93 KB, patch)
2012-02-18 01:53 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review
Setting LIST_ITEM role for categories (1.92 KB, patch)
2012-02-19 00:45 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
none Details | Review
Setting LIST_ITEM role for categories (1.93 KB, patch)
2012-02-20 19:30 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-18 01:43:29 UTC
STEPS TO REPRODUCE

1. Orca running
2. Move to overview (Alt+F1)
3. Select Applications view (Ctrl+Alt+Tab)
4. Navigate to the categories at the right side
5. Navigate along the categories

EXPECTED OUTCOME

"All", "Accessories", "Games" etc

ACTUAL OUTCOME

"button" "button" "button" etc

So: Name are not exposed, role is wrong
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-18 01:44:09 UTC
Created attachment 207908 [details] [review]
Expose StButton:label as accessible name
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-18 01:53:07 UTC
Created attachment 207909 [details] [review]
Setting MENU-ITEM role for the categories items

In this case we have some StButton. Although in theory the role should be BUTTON, in this case I really think that are not behaving like that. After thinking a little I guess that the proper role is MENU_ITEM, as for the user that section seems a menu (anyway, with the same reasoning, this could be also a LIST_ITEM). So I'm changing the Button role to MENU_ITEM. I also changed the container for all those buttons to MENU (as having MENU_ITEM(s) without MENU sounds odd to me).

Anyway, as I'm not 100%, CCing Joanmarie.
Comment 3 Joanmarie Diggs (IRC: joanie) 2012-02-18 02:17:48 UTC
 
> In this case we have some StButton. Although in theory the role should be
> BUTTON, in this case I really think that are not behaving like that.

Agreed.

> After
> thinking a little I guess that the proper role is MENU_ITEM, as for the user
> that section seems a menu (anyway, with the same reasoning, this could be also
> a LIST_ITEM).

Either of those seem reasonable, but.... I think what to me makes it more of a LIST_ITEM than a MENU_ITEM is how the user interacts with it. Normally when you activate a menu item and press Return, the menu is closed, focus moves, and the associated action gets performed. Here, nothing gets closed and focus doesn't move.

> So I'm changing the Button role to MENU_ITEM. I also changed the
> container for all those buttons to MENU (as having MENU_ITEM(s) without MENU
> sounds odd to me).

Agreed regarding the need to make an associated change in the container role. (So... presumably make it a LIST if you agree with my LIST_ITEM logic.)
Comment 4 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-19 00:45:55 UTC
Created attachment 207961 [details] [review]
Setting LIST_ITEM role for categories

Updated patch based on suggestion at comment 3
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-20 19:30:40 UTC
Created attachment 208057 [details] [review]
Setting LIST_ITEM role for categories

nitpick (just in case)
Comment 6 Dan Winship 2012-02-28 17:58:10 UTC
Comment on attachment 207908 [details] [review]
Expose StButton:label as accessible name

makes sense
Comment 7 Dan Winship 2012-02-28 17:58:56 UTC
Comment on attachment 208057 [details] [review]
Setting LIST_ITEM role for categories

yup
Comment 8 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-03-14 11:44:07 UTC
As first patch on bug 667432 was committed (that was the real dependency), and comment 6 and comment 7 didn't ask for further patch update, I have committed those patches. Closing as FIXED.