After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668726 - vorbisdeclib: support modern Tremor versions
vorbisdeclib: support modern Tremor versions
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.35
Other Linux
: Normal normal
: 0.10.37
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-01-26 10:29 UTC by Peter Korsgaard
Modified: 2012-03-14 14:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix (4.30 KB, patch)
2012-01-26 10:29 UTC, Peter Korsgaard 		committed Details | Review

Description Peter Korsgaard 2012-01-26 10:29:42 UTC 
Created attachment 206164 [details] [review]
patch to fix

Tremor changed to use standard libogg rather than its own incompatible
copy back in Aug 2010 (r17375), causing gst-plugin-base build to fail.
    
Tremolo so far unfortunately hasn't been updated. Restructure
vorbisdeclib.h so the int/float logic is seperate from the ogg handling,
and only use the legacy _ogg_packet_wrapper code for Tremolo.
Comment 1 Tim-Philipp Müller 2012-03-14 14:12:19 UTC 
Thanks, pushed:

 commit 787e896bdeb6c67d13a918ec55d3826fa010fb90
 Author: Peter Korsgaard <jacmet@sunsite.dk>
 Date:   Wed Jan 25 23:53:04 2012 +0100

    vorbisdec: support modern Tremor versions
    
    Tremor changed to use standard libogg rather than its own incompatible
    copy back in Aug 2010 (r17375), causing gst-plugin-base build to fail.
    
    Tremolo so far unfortunately hasn't been updated. Restructure
    vorbisdeclib.h so the int/float logic is seperate from the ogg handling,
    and only use the legacy _ogg_packet_wrapper code for Tremolo.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=668726