After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 668369 - EOG should assume sRGB with missing information
EOG should assume sRGB with missing information
Status: RESOLVED DUPLICATE of bug 554498
Product: eog
Classification: Core
Component: image viewer
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Reported: 2012-01-20 20:07 UTC by Pascal de Bruijn
Modified: 2014-04-02 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Assume sRGB when colorspace information is missing (2.08 KB, patch)
2012-01-20 20:07 UTC, Pascal de Bruijn
none Details | Review
Assume sRGB (476 bytes, patch)
2013-12-10 13:03 UTC, Pascal de Bruijn
rejected Details | Review

Description Pascal de Bruijn 2012-01-20 20:07:43 UTC
Created attachment 205727 [details] [review]
Assume sRGB when colorspace information is missing

In some casesm when EOG can't find good color space information in an image it seems to disable color management all together. So no conversion to the display color space is done even if the _ICC_PROFILE atom is set.

A sample image:

I think it's fairly sane behavior to assume sRGB if all else fails.

So I cobbled up a small patch which does just that. 

Do note, that I developed the patch for EOG 2.30.2 (tested on Debian Squeeze), however it seems to apply cleanly to EOG 3.3.4 (NOT tested).

Please do review this patch before committing.
Comment 1 Pascal de Bruijn 2012-01-20 20:10:56 UTC
The following bug may be related:
Comment 2 Felix Riemann 2012-01-25 21:55:20 UTC
Not sure if it's sane to use sRGB values as fallback values if either whitepoint or chromaticiy coords are missing. What happens if only one of the two values is missing ?

We should probably just fallback to "full" sRGB in case we can't build a profile from the Exif tags.
Comment 3 Pascal de Bruijn 2013-12-10 13:03:37 UTC
Created attachment 263912 [details] [review]
Assume sRGB

Assume sRGB when metadata is missing.
Comment 4 Pascal de Bruijn 2013-12-10 13:05:05 UTC
I just posted a patch adapted and tested with EOG 3.6.2.

I would love to see this in a new patch release for EOG 3.8 though.
Comment 5 Felix Riemann 2013-12-16 20:57:15 UTC
Review of attachment 263912 [details] [review]:

That patch is unfortunately not correct as it would overwrite an existing ICC profile.

I think we shouldn't make it JPEG-specific but should probably apply it to all image types (except SVG). Also I'd like to add support for GdkPixbuf's ICC reading feature as fallback (which would get us TIFF support). Maybe I can give it a look over the holidays.
Comment 6 Felix Riemann 2013-12-16 20:58:22 UTC
Oh, by the way eog-3.8 and 3.10 are in maintenance mode. So this would work as early as 3.12.
Comment 7 Felix Riemann 2014-04-02 16:34:54 UTC
Oh, this was fixed through bug 554498 and is in 3.12.
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.

*** This bug has been marked as a duplicate of bug 554498 ***