GNOME Bugzilla – Bug 668369
EOG should assume sRGB with missing information
Last modified: 2014-04-02 16:34:54 UTC
Created attachment 205727 [details] [review]
Assume sRGB when colorspace information is missing
In some casesm when EOG can't find good color space information in an image it seems to disable color management all together. So no conversion to the display color space is done even if the _ICC_PROFILE atom is set.
A sample image:
I think it's fairly sane behavior to assume sRGB if all else fails.
So I cobbled up a small patch which does just that.
Do note, that I developed the patch for EOG 2.30.2 (tested on Debian Squeeze), however it seems to apply cleanly to EOG 3.3.4 (NOT tested).
Please do review this patch before committing.
The following bug may be related:
Not sure if it's sane to use sRGB values as fallback values if either whitepoint or chromaticiy coords are missing. What happens if only one of the two values is missing ?
We should probably just fallback to "full" sRGB in case we can't build a profile from the Exif tags.
Created attachment 263912 [details] [review]
Assume sRGB when metadata is missing.
I just posted a patch adapted and tested with EOG 3.6.2.
I would love to see this in a new patch release for EOG 3.8 though.
Review of attachment 263912 [details] [review]:
That patch is unfortunately not correct as it would overwrite an existing ICC profile.
I think we shouldn't make it JPEG-specific but should probably apply it to all image types (except SVG). Also I'd like to add support for GdkPixbuf's ICC reading feature as fallback (which would get us TIFF support). Maybe I can give it a look over the holidays.
Oh, by the way eog-3.8 and 3.10 are in maintenance mode. So this would work as early as 3.12.
Oh, this was fixed through bug 554498 and is in 3.12.
Thanks for taking the time to report this bug.
This particular bug has already been reported into our bug tracking system, but we are happy to tell you that the problem has already been fixed. It should be solved in the next software version. You may want to check for a software upgrade.
*** This bug has been marked as a duplicate of bug 554498 ***