After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 667149 - Handle empty-string contact IDs
Handle empty-string contact IDs
Status: RESOLVED OBSOLETE
Product: folks
Classification: Platform
Component: Telepathy backend
git master
Other All
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2012-01-02 18:57 UTC by Philip Withnall
Modified: 2018-08-04 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Philip Withnall 2012-01-02 18:57:22 UTC 
There's nothing in the Tp specification which forbids a contact's ID from being the empty string. However, we use the contact's ID as their IM address, and forbid IM addresses from being empty strings.

There's a fundamental incompatibility here which should either result in us allowing empty strings as IM addresses, or (more likely) forbidding empty strings from being used as contact IDs by Telepathy.

(Found by my D-Bus simulator injecting an empty string as a contact ID into the results of a GetContactAttributes D-Bus call.)

Stack trace:

Core was generated by `/opt/gnome3/build/bin/empathy'.
Program terminated with signal 6, Aborted.

+ Trace 229371

  • #0 raise
    from /lib64/libc.so.6
  • #0 raise
    from /lib64/libc.so.6
  • #1 abort
    from /lib64/libc.so.6
  • #2 folks_im_field_details_construct
    at /opt/gnome2/source/folks/folks/im-details.vala line 65
  • #3 folks_im_field_details_new
    at /opt/gnome2/source/folks/folks/im-details.vala line 59
  • #4 tpf_persona_constructor
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona.vala line 672
  • #5 g_object_newv
    at gobject.c line 1622
  • #6 g_object_new_valist
    at gobject.c line 1739
  • #7 g_object_new
    at gobject.c line 1454
  • #8 tpf_persona_construct
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona.vala line 620
  • #9 tpf_persona_new
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona.vala line 613
  • #10 _tpf_persona_store_add_persona_from_contact
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona-store.vala line 2021
  • #11 __lambda4_
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona-store.vala line 1171
  • #12 ___lambda4__tp_connection_contacts_by_handle_cb
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona-store.vala line 1153
  • #13 contacts_context_continue
    at contact.c line 1845
  • #14 connection_capabilities_fetched_cb
    at contact.c line 2553
  • #15 g_simple_async_result_complete
    at gsimpleasyncresult.c line 744
  • #16 tp_connection_get_rcc_cb
    at connection.c line 544
  • #17 _tp_cli_dbus_properties_invoke_callback_get
    at _gen/tp-cli-generic-body.h line 764
  • #18 tp_proxy_pending_call_idle_invoke
    at proxy-methods.c line 153
  • #19 g_idle_dispatch
    at gmain.c line 4632
  • #20 g_main_dispatch
    at gmain.c line 2513
  • #21 g_main_context_dispatch
    at gmain.c line 3050
  • #22 g_main_context_iterate
    at gmain.c line 3121
  • #23 g_main_context_iteration
    at gmain.c line 3182
  • #24 g_application_run
    at gapplication.c line 1599
  • #25 main
    at empathy.c line 869
  • #4 tpf_persona_constructor
    at /opt/gnome2/source/folks/backends/telepathy/lib/tpf-persona.vala line 672 
$1 = (const gchar *) 0xa64420 ""
(gdb) print _tmp30_
$2 = (const gchar *) 0x778150 "proto"
Comment 1 GNOME Infrastructure Team 2018-08-04 08:33:06 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/folks/issues/38.