After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 666556 - [regression] build failure upgrading from 3.3.2 to 3.3.3
[regression] build failure upgrading from 3.3.2 to 3.3.3
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
3.3.x
Other Linux
: Normal critical
: GNOME3.4
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-12-19 20:18 UTC by David Ronis
Modified: 2014-07-07 18:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Ronis 2011-12-19 20:18:20 UTC
I just tried to upgrade eog (as part of an upgraded to gnome-3.3.3).   The build fails with:


make[4]: Entering directory `/home/ronis/Project/notar/GNOME/garnome/desktop/eog/work/main.d/eog-3.3.3/src'
/bin/sh ../libtool  --tag=CC   --mode=compile /usr/bin/gcc -DHAVE_CONFIG_H -I. -I..  -I../jpegutils -I../cut-n-paste/toolbar-editor -I../cut-n-paste/totem-screensaver -DG_LOG_DOMAIN=\"EOG\" -DEOG_PREFIX=\""/opt/garnome-svn-3.3.1"\" -DEOG_DATA_DIR=\""/opt/garnome-svn-3.3.1/share/eog"\" -DEOG_LOCALE_DIR=\""/opt/garnome-svn-3.3.1/share/locale"\" -DEOG_PIXMAPS_DIR=\""/opt/garnome-svn-3.3.1/share/pixmaps/eog"\" -DEOG_PLUGIN_DIR=\""/opt/garnome-svn-3.3.1/lib/eog/plugins"\" -DLIBDIR=\""/opt/garnome-svn-3.3.1/lib"\" -I/opt/garnome-svn-3.3.1/include -pthread -I/opt/garnome-svn-3.3.1/include/gtk-3.0 -I/opt/garnome-svn-3.3.1/include/atk-1.0 -I/opt/garnome-svn-3.3.1/include/cairo -I/opt/garnome-svn-3.3.1/include/gdk-pixbuf-2.0 -I/opt/garnome-svn-3.3.1/include/pango-1.0 -I/opt/garnome-svn-3.3.1/include/gio-unix-2.0/ -I/opt/garnome-svn-3.3.1/include -I/opt/garnome-svn-3.3.1/include/glib-2.0 -I/opt/garnome-svn-3.3.1/lib/glib-2.0/include -I/opt/garnome-svn-3.3.1/include/freetype2 -I/opt/garnome-svn-3.3.1/include/gnome-desktop-3.0 -I/opt/garnome-svn-3.3.1/include/gtk-3.0/unix-print -I/opt/garnome-svn-3.3.1/include/libpeas-1.0 -I/opt/garnome-svn-3.3.1/include/gobject-introspection-1.0 -I/opt/garnome-svn-3.3.1/include/librsvg-2.0 -I/opt/garnome-svn-3.3.1/include/gsettings-desktop-schemas -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/lib/libffi-3.0.9/include -I/usr/include/libexif   -Wall -Wmissing-prototypes   -I/opt/garnome-svn-3.3.1/include -L/opt/garnome-svn-3.3.1/lib -O2 -g -pipe -MT libeog_la-eog-metadata-sidebar.lo -MD -MP -MF .deps/libeog_la-eog-metadata-sidebar.Tpo -c -o libeog_la-eog-metadata-sidebar.lo `test -f 'eog-metadata-sidebar.c' || echo './'`eog-metadata-sidebar.c
libtool: compile:  /usr/bin/gcc -DHAVE_CONFIG_H -I. -I.. -I../jpegutils -I../cut-n-paste/toolbar-editor -I../cut-n-paste/totem-screensaver -DG_LOG_DOMAIN=\"EOG\" -DEOG_PREFIX=\"/opt/garnome-svn-3.3.1\" -DEOG_DATA_DIR=\"/opt/garnome-svn-3.3.1/share/eog\" -DEOG_LOCALE_DIR=\"/opt/garnome-svn-3.3.1/share/locale\" -DEOG_PIXMAPS_DIR=\"/opt/garnome-svn-3.3.1/share/pixmaps/eog\" -DEOG_PLUGIN_DIR=\"/opt/garnome-svn-3.3.1/lib/eog/plugins\" -DLIBDIR=\"/opt/garnome-svn-3.3.1/lib\" -I/opt/garnome-svn-3.3.1/include -pthread -I/opt/garnome-svn-3.3.1/include/gtk-3.0 -I/opt/garnome-svn-3.3.1/include/atk-1.0 -I/opt/garnome-svn-3.3.1/include/cairo -I/opt/garnome-svn-3.3.1/include/gdk-pixbuf-2.0 -I/opt/garnome-svn-3.3.1/include/pango-1.0 -I/opt/garnome-svn-3.3.1/include/gio-unix-2.0/ -I/opt/garnome-svn-3.3.1/include -I/opt/garnome-svn-3.3.1/include/glib-2.0 -I/opt/garnome-svn-3.3.1/lib/glib-2.0/include -I/opt/garnome-svn-3.3.1/include/freetype2 -I/opt/garnome-svn-3.3.1/include/gnome-desktop-3.0 -I/opt/garnome-svn-3.3.1/include/gtk-3.0/unix-print -I/opt/garnome-svn-3.3.1/include/libpeas-1.0 -I/opt/garnome-svn-3.3.1/include/gobject-introspection-1.0 -I/opt/garnome-svn-3.3.1/include/librsvg-2.0 -I/opt/garnome-svn-3.3.1/include/gsettings-desktop-schemas -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/usr/lib/libffi-3.0.9/include -I/usr/include/libexif -Wall -Wmissing-prototypes -I/opt/garnome-svn-3.3.1/include -L/opt/garnome-svn-3.3.1/lib -O2 -g -pipe -MT libeog_la-eog-metadata-sidebar.lo -MD -MP -MF .deps/libeog_la-eog-metadata-sidebar.Tpo -c eog-metadata-sidebar.c  -fPIC -DPIC -o .libs/libeog_la-eog-metadata-sidebar.o
eog-metadata-sidebar.c: In function 'eog_metadata_sidebar_update_metadata_section':
eog-metadata-sidebar.c:256:2: error: unknown type name 'XmpPtr'
eog-metadata-sidebar.c:256:20: warning: initialization makes integer from pointer without a cast [enabled by default]
eog-metadata-sidebar.c:261:12: warning: assignment makes integer from pointer without a cast [enabled by default]
eog-metadata-sidebar.c:256:9: warning: variable 'xmp_data' set but not used [-Wunused-but-set-variable]
make[4]: *** [libeog_la-eog-metadata-sidebar.lo] Error 1
make[4]: Leaving directory `/home/ronis/Project/notar/GNOME/garnome/desktop/eog/work/main.d/eog-3.3.3/src'
Comment 1 Felix Riemann 2011-12-19 21:15:19 UTC
Looks like I forgot some #ifdef's for people that build without exempi and/or libexif in the metadata sidebar.
Comment 2 David Ronis 2011-12-19 21:35:44 UTC
I have libexif installed:

pkg-config --modversion libexif
0.6.20
Comment 3 Felix Riemann 2011-12-19 21:45:34 UTC
(In reply to comment #2)
> I have libexif installed:
> 
> pkg-config --modversion libexif
> 0.6.20

Sure, but you don't have exempi and the build failed if any of them was missing (with different error messages of course).

But this should help:

commit deb2b63128a14dbec75c165e041c6da5023bf54e
Author: Felix Riemann <>
Date:   Mon Dec 19 22:41:38 2011 +0100

    Fix build when not building with libexif and/or exempi

    There were quite some #ifdefs missing.

    https://bugzilla.gnome.org/show_bug.cgi?id=666556

This problem has been fixed in the development version. The fix will be
available in the next major software release. Thank you for your bug report.
Comment 4 David Ronis 2011-12-19 22:02:17 UTC
I applied the patch, thanks.  The build still dies with:

LC_ALL=C /opt/garnome-svn-3.3.1/bin/intltool-merge -x -u --no-translations org.gnome.eog.gschema.xml.in org.gnome.eog.gschema.xml
  GEN    org.gnome.eog.enums.xml
Found cached translation database
Unknown option: no-translations
Undefined subroutine &main::error called at /opt/garnome-svn-3.3.1/bin/intltool-merge line 73.
make[4]: *** [org.gnome.eog.gschema.xml] Error 255

This is probably some other bug.
Comment 5 David Ronis 2011-12-19 22:06:40 UTC
Indeed it was.  My intltool was too old.  Upgrading to 0.50.0 fixes the problem.
Comment 6 Felix Riemann 2011-12-20 17:39:52 UTC
(In reply to comment #5)
> Indeed it was.  My intltool was too old.  Upgrading to 0.50.0 fixes the
> problem.

Oh, that shouldn't be. I either need to watch out for my intltool version when building tarballs or I need to raise the minimum version in the configure script.
Comment 7 bingquick 2014-07-03 05:54:34 UTC
A possible similar bug on eog-3.13.2 too:

When build eog-3.13.2 with "--without-xmp" option:

configure summary:

	Source code location .......:  .
	Compiler ...................:  gcc
	Extra Compiler Warnings ....:   -Wall -Wstrict-prototypes -Wnested-externs -Werror=missing-prototypes -Werror=implicit-function-declaration -Werror=pointer-arith -Werror=init-self -Werror=format-security -Werror=format=2 -Werror=missing-include-dirs 

	EXIF support ...............:  yes
	XMP support ................:  no
	JPEG support ...............:  yes
	Colour management support ..:  yes
	GObject Introspection.......:  yes

Compiler gave this error:

eog-properties-dialog.c: In function 'eog_properties_dialog_class_init':
eog-properties-dialog.c:644:2: error: 'EogPropertiesDialogPrivate' has no member named 'xmp_box'
eog-properties-dialog.c:647:2: error: 'EogPropertiesDialogPrivate' has no member named 'xmp_box_label'

Maybe they are not defined/initialized properly?
Comment 8 Felix Riemann 2014-07-07 18:31:21 UTC
(In reply to comment #7)
> Maybe they are not defined/initialized properly?

No, the code is probably trying to work on variables that are not defined unless you build with XMP support. Can you please open a new bug report for easier reference? While it is related, it's not exactly the same. Thanks.