After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 661841 - [edgetv] video artifacts if videorate placed after edgetv
[edgetv] video artifacts if videorate placed after edgetv
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-10-15 12:31 UTC by Oleksij Rempel
Modified: 2011-11-24 10:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
edgetv: don't leave bits of the output buffer uninitialized (1.18 KB, patch)
2011-10-31 17:07 UTC, Vincent Penquerc'h
committed Details | Review
edgetv: trivial comment fix for clarity (937 bytes, patch)
2011-10-31 17:07 UTC, Vincent Penquerc'h
committed Details | Review

Description Oleksij Rempel 2011-10-15 12:31:24 UTC
If i set videorate before edgetv, every things is fine. if i set it after, then i get some artifacts 
 here is the pipe "gst-launch -v v4l2src ! video/x-raw-rgb, width=640, height=480, framerate=15/1 ! ffmpegcolorspace ! edgetv ! videorate ! ffmpegcolorspace ! autovideosink"

I think this issue is introduced by edgetv.
Comment 1 Vincent Penquerc'h 2011-10-31 17:07:08 UTC
Created attachment 200351 [details] [review]
edgetv: don't leave bits of the output buffer uninitialized

Let's initialize them to zero. It looks alright, but then it
also looks alright with v3, or with the corresponding pixels
from the source. I don't know what the original intent would
be, and the original effectv source also has this bug/feature.
Comment 2 Vincent Penquerc'h 2011-10-31 17:07:11 UTC
Created attachment 200352 [details] [review]
edgetv: trivial comment fix for clarity
Comment 3 Oleksij Rempel 2011-10-31 19:30:04 UTC
Great, thank you!
it looks almost perfect now. But i still get  ~5 pixel flickering border around frame. Is it possible to fix it?
Comment 4 Sebastian Dröge (slomo) 2011-11-24 09:43:31 UTC
commit cbbabd6ccca6bdada309f42f1f8998dc1db94962
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Oct 31 17:06:18 2011 +0000

    edgetv: trivial comment fix for clarity
    
    https://bugzilla.gnome.org/show_bug.cgi?id=661841

commit 852104b4eee0609ad62abc87ca6f014d1a4a63cd
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Mon Oct 31 17:04:23 2011 +0000

    edgetv: don't leave bits of the output buffer uninitialized
    
    Let's initialize them to zero. It looks alright, but then it
    also looks alright with v3, or with the corresponding pixels
    from the source. I don't know what the original intent would
    be, and the original effectv source also has this bug/feature.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=661841