After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 652964 - Segfault when RBAudioscrobbler finalizes and queue needs saved
Segfault when RBAudioscrobbler finalizes and queue needs saved
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: last.fm
HEAD
Other Linux
: Normal critical
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-06-19 23:16 UTC by Jamie Nicol
Modified: 2011-06-20 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
backtrace (9.11 KB, text/plain)
2011-06-19 23:16 UTC, Jamie Nicol
  Details
save queue in dispose instead of finalize (1.17 KB, patch)
2011-06-19 23:17 UTC, Jamie Nicol
committed Details | Review

Description Jamie Nicol 2011-06-19 23:16:48 UTC
Created attachment 190240 [details]
backtrace

The service object is needed to calculate the filename, but service is destroyed in dispose and the queue is saved in finalize.

patch to follow.
Comment 1 Jamie Nicol 2011-06-19 23:17:57 UTC
Created attachment 190241 [details] [review]
save queue in dispose instead of finalize
Comment 2 Jonathan Matthew 2011-06-20 09:40:55 UTC
Review of attachment 190241 [details] [review]:

Looks right.  Please commit this to the v0.13.x branch too.
Comment 3 Jamie Nicol 2011-06-20 19:34:25 UTC
Fix pushed to master and v0.13.x