Bug 652397 – Crash when naming a preset "Default"

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 652397 - Crash when naming a preset "Default"


Summary:	Crash when naming a preset "Default"


Status:	RESOLVED FIXED

Product:	pitivi
Classification:	Other
Component:	User interface
Version:	0.14
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	0.14.1
Assigned To:	Pitivi maintainers
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-06-12 15:18 UTC by Hicham HAOUARI
Modified:	2011-06-28 02:39 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Hicham HAOUARI 2011-06-12 15:18:56 UTC

Original bug is at : https://bugzilla.redhat.com/show_bug.cgi?id=712700

How to reproduce this crash :

- Try to add a preset named as "Default"

Comment 1 Jean-François Fortin Tam 2011-06-12 15:53:00 UTC

Indeed, wtf. Seems like configparser, for some reason, doesn't like "Default".

Traceback (most recent call last):

+ Trace 227449

File "pitivi/ui/projectsettings.py", line 459 in _responseCb
```
self.video_presets.save()
```
File "pitivi/ui/preset.py", line 52 in save
```
self._save(parser)
```
File "pitivi/ui/preset.py", line 61 in _save
```
self.saveSection(parser, name)
```
File "pitivi/ui/preset.py", line 151 in saveSection
```
parser.add_section(section)
```
File "/usr/lib/python2.7/ConfigParser.py", line 253 in add_section
```
raise ValueError, 'Invalid section name: %s' % section
```

ValueError: Invalid section name: Default



I'm not sure why that is, but I guess we have to work around it...

Comment 2 Hicham HAOUARI 2011-06-13 01:30:35 UTC

https://github.com/aleb/pitivi/commit/cd27e9a0d9e3e09e268c951af1da893df7a12cc4 creates another traceback :

Traceback (most recent call last):

+ Trace 227454

File "/usr/share/pitivi/python/pitivi/ui/projectsettings.py", line 421 in _responseCb
```
self.video_presets.save()
```
File "/usr/share/pitivi/python/pitivi/ui/preset.py", line 58 in save
```
self._savePresetsToParser(parser)
```
File "/usr/share/pitivi/python/pitivi/ui/preset.py", line 73 in _savePresetsToParser
```
self._savePreset(parser, section, values)
```
File "/usr/share/pitivi/python/pitivi/ui/preset.py", line 96 in _savePreset
```
raise NotImplemented
```

TypeError: exceptions must be old-style classes or derived from BaseException, not NotImplementedType

Comment 3 Alex Băluț 2011-06-13 05:26:31 UTC

Hicham, thanks for testing.

Did you apply the patch(es) correctly? Try (on HEAD=d7a5c20f9053de448c02f46aeb24ba11114ea786) this, and tell us how it works:
wget "https://github.com/aleb/pitivi/commit/3e884351a9a03b8a53d04cf4f3204b1cec64510b.diff"
wget "https://github.com/aleb/pitivi/commit/6b77b82df12b12f31f3e56446f22bc543e70d9f6.diff"
git apply 3e884351a9a03b8a53d04cf4f3204b1cec64510b.diff
git apply 6b77b82df12b12f31f3e56446f22bc543e70d9f6.diff --include pitivi/ui/
bin/pitivi

Comment 4 Hicham HAOUARI 2011-06-14 15:50:07 UTC

Now it works after these two commits, thanks

Comment 5 Jean-François Fortin Tam 2011-06-28 02:39:44 UTC

commit 37f6325278d3fb20e000288b3fc8366da3940b7f
Author: Alex Băluț <alexandru.balut@gmail.com>
Date:   Sun Jun 12 22:21:20 2011 +0200
 
    Changed PresetManager to allow the user to have a preset called Default.
    Fixes bug 652397.