After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 650530 - GtkAssistant beautification patches
GtkAssistant beautification patches
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-05-18 21:27 UTC by Cosimo Cecchi
Modified: 2011-05-19 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
assistant: remove an useless gtk_widget_reset_style() call (1.02 KB, patch)
2011-05-18 21:27 UTC, Cosimo Cecchi
committed Details | Review
assistant: pack the sidebar in a frame instead of an event box (3.73 KB, patch)
2011-05-18 21:27 UTC, Cosimo Cecchi
committed Details | Review
This wasn't possible before (186.92 KB, image/png)
2011-05-18 21:28 UTC, Cosimo Cecchi
  Details

Description Cosimo Cecchi 2011-05-18 21:27:31 UTC
Attached two patches that allow the theme to improve its control over the assistant appearance.
Comment 1 Cosimo Cecchi 2011-05-18 21:27:33 UTC
Created attachment 188078 [details] [review]
assistant: remove an useless gtk_widget_reset_style() call

It's not needed to call _reset_style() here, as we did not add the
widget to the parent container yet.
Comment 2 Cosimo Cecchi 2011-05-18 21:27:35 UTC
Created attachment 188079 [details] [review]
assistant: pack the sidebar in a frame instead of an event box

This has mostly two advantages:
- the most obvious one is the theme can render a border around the
  sidebar if it wants to.
- we also can avoid hardcoding a container border width for the sidebar,
  and just use a padding from the theme. This also allows different
  themes to define a different padding, etc.

The drawback is we must draw the background ourselves, but it's easy
enough.
Comment 3 Cosimo Cecchi 2011-05-18 21:28:27 UTC
Created attachment 188080 [details]
This wasn't possible before
Comment 4 Matthias Clasen 2011-05-19 14:40:35 UTC
Review of attachment 188078 [details] [review]:

Looks like some leftover. Please commit
Comment 5 Matthias Clasen 2011-05-19 14:42:56 UTC
Review of attachment 188079 [details] [review]:

Looks great to me.
Comment 6 Cosimo Cecchi 2011-05-19 14:54:47 UTC
Pushed to master both patches.

Attachment 188078 [details] pushed as 6bbb9d6 - assistant: remove an useless gtk_widget_reset_style() call
Attachment 188079 [details] pushed as 8301b24 - assistant: pack the sidebar in a frame instead of an event box