GNOME Bugzilla – Bug 643582
LetsSingIt.com lyrics
Last modified: 2018-05-24 15:52:13 UTC
Created attachment 182174 [details] The parser A lyrics searcher for LetsSingIt.com, for the "Lyrics" plugin. Copied from another lyrics plugins (author copyrights not removed) and modified to get lyrics from LetsSingIt.com. There must be a line added in LyricsSites.py: lyrics_sites = [ ... { 'id': 'letssingit.com', 'class': LetsSingItParser, 'name': _("LetsSingIt (letssingit.com)") }, ... ]
Well, I forgot to remove some (non-working) debugging... === modified file 'LetsSingItParser.py' --- LetsSingItParser.py 2011-03-01 12:03:03 +0000 +++ LetsSingItParser.py 2011-03-01 12:03:32 +0000 @@ -35,8 +35,6 @@ before = '<PRE id=lyrics>' after = '</PRE>' - log = open('lsi.txt', 'w') - def __init__(self, artist, title): self.artist = artist self.title = title @@ -49,7 +47,6 @@ wurl = 'cgi-exe/am.cgi?a=search&l=song&s="%s+-+%s"' % (wartist, wtitle) loader = rb.Loader() - log.write('\n'+path+wurl+'\n') loader.get_url (path + wurl, self.got_lyrics, callback, *data) def got_lyrics(self, lyrics, callback, *data):
Please upload a single patch that includes all changes required to add this site. I'm not going to pick changes out of comments.
Created attachment 182181 [details] [review] Patch from source git tree This is a real patch, but I couldn't test it because I'm on Ubuntu which doesn't have the latest versions of the libraries needed to build rhythmbox.
Comment on attachment 182174 [details] The parser Now obsolete
Created attachment 183627 [details] [review] Patch with two bugs fixed Fixes two bugs: * LetsSingIt.com was not added to LyricsSites.py (now added, should work, haven't tested because I can't test it here) * There didn't show up any lyrics, because the test for 'lyrics not available' returned true when there weren't any lyrics and false when there were... Ouch! Thanks for merging the previous patch! But it won't be usable without this patch...
Created attachment 183636 [details] [review] Fix in the patch Forgot to remove debugging code
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1060.