After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 643582 - LetsSingIt.com lyrics
LetsSingIt.com lyrics
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other All
: Normal enhancement
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-01 11:53 UTC by Ayke van Laethem
Modified: 2018-05-24 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The parser (2.45 KB, text/x-python)
2011-03-01 11:53 UTC, Ayke van Laethem
  Details
Patch from source git tree (2.69 KB, patch)
2011-03-01 14:47 UTC, Ayke van Laethem
none Details | Review
Patch with two bugs fixed (1.58 KB, patch)
2011-03-17 14:01 UTC, Ayke van Laethem
none Details | Review
Fix in the patch (1.65 KB, patch)
2011-03-17 15:06 UTC, Ayke van Laethem
none Details | Review

Description Ayke van Laethem 2011-03-01 11:53:33 UTC
Created attachment 182174 [details]
The parser

A lyrics searcher for LetsSingIt.com, for the "Lyrics" plugin.

Copied from another lyrics plugins (author copyrights not removed) and modified to get lyrics from LetsSingIt.com.

There must be a line added in LyricsSites.py:

lyrics_sites = [
...
    { 'id': 'letssingit.com',   'class': LetsSingItParser,  'name': _("LetsSingIt (letssingit.com)")    },
...
]
Comment 1 Ayke van Laethem 2011-03-01 12:10:56 UTC
Well, I forgot to remove some (non-working) debugging...

=== modified file 'LetsSingItParser.py'
--- LetsSingItParser.py	2011-03-01 12:03:03 +0000
+++ LetsSingItParser.py	2011-03-01 12:03:32 +0000
@@ -35,8 +35,6 @@
 	before = '<PRE id=lyrics>'
 	after  = '</PRE>'
 
-	log = open('lsi.txt', 'w')
-
 	def __init__(self, artist, title):
 		self.artist = artist
 		self.title = title
@@ -49,7 +47,6 @@
 		wurl = 'cgi-exe/am.cgi?a=search&l=song&s="%s+-+%s"' % (wartist, wtitle)
 
 		loader = rb.Loader()
-		log.write('\n'+path+wurl+'\n')
 		loader.get_url (path + wurl, self.got_lyrics, callback, *data)
 
 	def got_lyrics(self, lyrics, callback, *data):
Comment 2 Jonathan Matthew 2011-03-01 12:20:52 UTC
Please upload a single patch that includes all changes required to add this site.  I'm not going to pick changes out of comments.
Comment 3 Ayke van Laethem 2011-03-01 14:47:52 UTC
Created attachment 182181 [details] [review]
Patch from source git tree

This is a real patch, but I couldn't test it because I'm on Ubuntu which doesn't have the latest versions of the libraries needed to build rhythmbox.
Comment 4 Ayke van Laethem 2011-03-01 14:49:03 UTC
Comment on attachment 182174 [details]
The parser

Now obsolete
Comment 5 Ayke van Laethem 2011-03-17 14:01:02 UTC
Created attachment 183627 [details] [review]
Patch with two bugs fixed

Fixes two bugs:
 * LetsSingIt.com was not added to LyricsSites.py (now added, should work, haven't tested because I can't test it here)
 * There didn't show up any lyrics, because the test for 'lyrics not available' returned true when there weren't any lyrics and false when there were... Ouch!

Thanks for merging the previous patch! But it won't be usable without this patch...
Comment 6 Ayke van Laethem 2011-03-17 15:06:05 UTC
Created attachment 183636 [details] [review]
Fix in the patch

Forgot to remove debugging code
Comment 7 GNOME Infrastructure Team 2018-05-24 15:52:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/1060.