After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 642938 - scripts that require brushes that GIMP no longer installs
scripts that require brushes that GIMP no longer installs
Status: RESOLVED OBSOLETE
Product: GIMP
Classification: Other
Component: Script-Fu
git master
Other All
: High normal
: 2.10
Assigned To: GIMP Bugs
GIMP Bugs
: 765834 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-02-22 04:04 UTC by Carol Spears
Modified: 2018-05-24 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scripts generate brushes instead of looking for brushes that don't exist and failing (5.97 KB, patch)
2011-02-22 04:04 UTC, Carol Spears
none Details | Review
patch for spyrogimp.scm (2.87 KB, patch)
2011-02-22 06:09 UTC, Carol Spears
needs-work Details | Review
this patch solves the problem of scripts requiring brushes that are not available (7.46 KB, patch)
2011-02-23 08:58 UTC, Carol Spears
needs-work Details | Review

Description Carol Spears 2011-02-22 04:04:35 UTC
Created attachment 181552 [details] [review]
scripts generate brushes instead of looking for brushes that don't exist and failing

plug-ins/script-fu/scripts/carve-it.scm
plug-ins/script-fu/scripts/carved-logo.scm
plug-ins/script-fu/scripts/chrome-it.scm

These scripts require brushes that were removed from the brushes that 
GIMP installs (96a6e5c2db2bed568c17bd149e92f1239a702763).

Recommend either restoring the brushes or converting the scripts to 
generate brushes as needed (a patch should be included which accomplishes
this).
Comment 1 Carol Spears 2011-02-22 06:09:32 UTC
Created attachment 181557 [details] [review]
patch for spyrogimp.scm

spyrogimp.scm breaks when run with its default settings which name a brush that 
is no longer installed.

I do not know if the patch attached is an improvement or not -- instead of requesting a brush, it asks for a radius and a paint mode and makes a new brush, 
uses that and then deletes the brush.  The choice of installed brushes is not so
good for spyrogimp.

The patched script also shows (at least here) how badly broken GIMP brushes are
for regular old scripted painting.  The default brush (which is a radius of .5px) is painting with a radius of twice that much or more.

The script does everything correctly though.
Comment 2 Carol Spears 2011-02-22 06:11:42 UTC
"painting with a radius of twice that much or more" should be "painting with a
radius of 10 times that or more".

oops
Comment 3 Carol Spears 2011-02-23 08:58:15 UTC
Created attachment 181678 [details] [review]
this patch solves the problem of scripts requiring brushes that are not available

This patch makes vector brushes when brushes are actually needed by script-fu.
t-o-p-logo (Particle Trace) was requiring brushes it never used (and has been
needlessly requiring them since gimp-1.2).
Comment 4 Michael Schumacher 2015-11-01 13:48:40 UTC
Comment on attachment 181557 [details] [review]
patch for spyrogimp.scm

Pretty sure this needs some more adjustments in regard to gimp-context (e.g. for the size)
Comment 5 Michael Natterer 2016-05-03 10:25:33 UTC
*** Bug 765834 has been marked as a duplicate of this bug. ***
Comment 6 Michael Natterer 2016-05-03 10:26:55 UTC
We should really have addressed this long ago, let's at least fix
it in 2.10. Thanks for the patch Carol.
Comment 7 Michael Schumacher 2016-05-28 20:45:21 UTC
Seems to me that this needs some additional work, though - setting the brush radius is not going to affect the size used anymore, is it?
Comment 8 GNOME Infrastructure Team 2018-05-24 12:57:51 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gimp/issues/360.