After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638775 - [PATCH] Vastly simplify default-application icon use
[PATCH] Vastly simplify default-application icon use
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-05 21:35 UTC by Michael Terry
Modified: 2011-03-17 14:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (18.04 KB, patch)
2011-01-05 21:36 UTC, Michael Terry
none Details | Review

Description Michael Terry 2011-01-05 21:35:39 UTC
Hi!  In the course of fixing why icons didn't show up for web applications (it was because g_app_info_get_name is almost never a suitable themed icon name), I simplified a lot of the icon logic in the default-application panel.  Now it doesn't have to care about screen or theme changes.

Patch attached.
Comment 1 Michael Terry 2011-01-05 21:36:11 UTC
Created attachment 177615 [details] [review]
Proposed patch
Comment 2 Bastien Nocera 2011-03-17 14:43:50 UTC
The code in the default applications section in the Info panel doesn't load the icons itself anymore. If there is a bug handling those particular web applications, please file it directly against GTK+.