GNOME Bugzilla – Bug 637123
Decimal aspect ratios are shown in E notation
Last modified: 2015-10-20 13:25:30 UTC
If you enter "1.333" as a pixel aspect ratio, it seems pitivi will accept it/parse it fine, but the resulting DAR will be "7.50412e+15:4.5036e+15", which is a bit strange/hard to read. I'm wondering if there's anything we can do about that.
Created attachment 243141 [details] [review] proposed solution Commit message: --- Optional attribute 'fracthreshold' added to constructor Defaults to None (no change in behavior) If num or denom > threshold, display a floating point number instead Also use the parameter in the project settings dialog for dar/par. --- It's worth noting that with this patch, the dar/par output generally matches the input (ie, typing in a decimal for dar will print a decimal for par, and likewise for ratios).
Interesting, though so far I haven't figured out the reasoning behind those changes and how they actually solve the problem. Also, if you try to enter 1.33 or 4.33 as an aspect ratio, you get various errors: (pitivi:24976): GStreamer-CRITICAL **: gst_value_set_fraction: assertion `denominator != 0' failed pitivi/viewer.py:284: Warning: value "0,000000" of type `gfloat' is invalid or out of range for property `ratio' of type `gfloat' self.aframe.set_property("ratio", float(ratio))
This bug has been migrated to https://phabricator.freedesktop.org/T2721. Please use the Phabricator interface to report further bugs by creating a task and associating it with Project: Pitivi. See http://wiki.pitivi.org/wiki/Bug_reporting for details.