After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637032 - [PATCH] Add support to GObjectIntrospection
[PATCH] Add support to GObjectIntrospection
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: API
git master
Other Linux
: Normal normal
: ---
Assigned To: Dan Williams
Dan Williams
Depends on:
Blocks: 585444 621707
 
 
Reported: 2010-12-11 18:05 UTC by Giovanni Campagna
Modified: 2011-02-22 00:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add GObjectIntrospection support (51.15 KB, patch)
2010-12-11 18:06 UTC, Giovanni Campagna
none Details | Review
Add GObjectIntrospection support (53.20 KB, patch)
2010-12-30 19:48 UTC, Giovanni Campagna
none Details | Review
Add GObjectIntrospection support (65.39 KB, patch)
2011-01-14 17:58 UTC, Giovanni Campagna
none Details | Review
More GObjectIntrospection fixes (7.08 KB, patch)
2011-01-22 14:29 UTC, Giovanni Campagna
none Details | Review
More GObjectIntrospection fixes (8.13 KB, patch)
2011-02-20 16:39 UTC, Giovanni Campagna
none Details | Review

Description Giovanni Campagna 2010-12-11 18:05:01 UTC
GObjectIntrospection allows bindings like gjs or pygobject to use libnm, thus allowing a NM client in Javascript or Python (actually many others).
This is required for the future network indicator in gnome-shell.
Comment 1 Giovanni Campagna 2010-12-11 18:06:00 UTC
Created attachment 176247 [details] [review]
Add GObjectIntrospection support

Add the necessary annotations (the mininum required, that is those
on return values. NULL parameters or container types may require
more), and the Autotools stuff to get a NetworkManager GIR for
libnm-util and a NMClient for libnm-glib.
Based on top of the rm-userset branch.
Comment 2 Dan Williams 2010-12-16 00:05:44 UTC
Hey, thanks a lot, looks like good work.  I saw some trivial bits that I pulled out and committed separately since they are applicable to both 0.8.x and master.  I'll review the rest of the patch soon!
Comment 3 Giovanni Campagna 2010-12-30 19:48:32 UTC
Created attachment 177276 [details] [review]
Add GObjectIntrospection support

Add the necessary annotations (the mininum required, that is those
on return values. NULL parameters or container types may require
more), and the Autotools stuff to get a NetworkManager GIR for
libnm-util and a NMClient for libnm-glib.
Based on top of the rm-userset branch.

Updated on current master, also includes a compatible API change
(nm_remote_settings_new now accepts NULL, which is required for bindings
which don't have DBusGConnection)
Comment 4 Giovanni Campagna 2011-01-14 17:58:37 UTC
Created attachment 178338 [details] [review]
Add GObjectIntrospection support

Add the necessary annotations (the mininum required, that is those
on return values. NULL parameters or container types may require
more), and the Autotools stuff to get a NetworkManager GIR for
libnm-util and a NMClient for libnm-glib.
Also, some minor bug fixes.

Rebased and extended for WiMax.
Comment 5 Dan Williams 2011-01-21 22:47:41 UTC
Thanks again!  Pushed as:

3ebecd2a295b40081321d1b3f26fb1204fe5d4c4
Comment 6 Giovanni Campagna 2011-01-22 14:28:38 UTC
Reopening because the addition of new functions make introspection fail, some functions are still missing from the linker script, and some annotations are just useless (marking GHashTables of gpointer).
Patch coming.
Comment 7 Giovanni Campagna 2011-01-22 14:29:09 UTC
Created attachment 179038 [details] [review]
More GObjectIntrospection fixes

Fix some annotations, add the necessary ones for new functions,
and ensure that all public symbols are exported.
Comment 8 Giovanni Campagna 2011-02-20 16:39:42 UTC
Created attachment 181415 [details] [review]
More GObjectIntrospection fixes

Fix some annotations and add the necessary ones for new functions.

Updated to master.
Comment 9 Dan Williams 2011-02-22 00:11:08 UTC
Split into 3:

e77acd43b663b3e1011f812bc506c176f65d1415
3b57350dd6d1f1b48119eb66dc170aaf2aef1dc3
8bc774fe16039add71f68ea7f7e5a739803803bf

Thanks!