After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636938 - [PATCH] Add Introspection support
[PATCH] Add Introspection support
Product: tracker
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Martyn Russell
Jamie McCracken
Depends on:
Reported: 2010-12-10 07:22 UTC by Javier Jardón (IRC: jjardon)
Modified: 2011-05-03 08:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Add introspection support in libtracker-miner (3.09 KB, patch)
2010-12-10 07:41 UTC, Javier Jardón (IRC: jjardon)
none Details | Review
Updated patch (3.02 KB, patch)
2010-12-10 10:39 UTC, Martyn Russell
needs-work Details | Review
Add introspection support in libtracker-miner.v2 (6.78 KB, patch)
2010-12-10 17:51 UTC, Javier Jardón (IRC: jjardon)
committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-12-10 07:22:04 UTC
Comment 1 Javier Jardón (IRC: jjardon) 2010-12-10 07:41:38 UTC
Created attachment 176165 [details] [review]
Add introspection support in libtracker-miner

Note that I have to remove the acinclude.m4 file as the IDT_COMPILE_WARNINGS add the Wall flag to CFLAGS and this is not correct and causes a conflict in the gir scanner
Comment 2 Martyn Russell 2010-12-10 10:39:31 UTC
Created attachment 176170 [details] [review]
Updated patch

Hi Javier,

Great patch thank you.
Unfortunately, it fails on HAVE_INTROSPECTION for me:

autoreconf: running: automake --add-missing --copy --force-missing
src/libtracker-miner/ HAVE_INTROSPECTION does not appear in AM_CONDITIONAL

I suspect this is supposed to be defined in the GOBJECT_INTROSPECTION_CHECK macro? or in (which it currently doesn't).

Also, I updated the patch to:

  1. Use the Git commit policy correctly:

  2. Change "TrackerMiner-1.0.gir" for "TrackerMiner-0_10.gir" as that's the
     (stable) version about to be released.
Comment 3 Martyn Russell 2010-12-10 10:41:23 UTC
Actually about the patch point #2, perhaps we should use $TRACKER_API_VERSION there to avoid issues in the future too.
Comment 4 Javier Jardón (IRC: jjardon) 2010-12-10 15:27:27 UTC
Hello Martyn,

I can't your issue here. Try to completely clean the source tree and try again.

Also, note that this only add introspection to libtracker-miner, more patches are needed for the other tracker libraries
Comment 5 Martyn Russell 2010-12-10 15:35:22 UTC
martyn@petunia:~/Source/tracker$ git clean -dfx


martyn@petunia:~/Source/tracker$ git am foo.diff
Applying: libtracker-miner: Add introspection support
martyn@petunia:~/Source/tracker$ ./ --with-session-bus-services-dir=$(datadir)/dbus-1/services --enable-nautilus-extension --enable-unit-tests --enable-functional-tests --enable-gtk-doc --enable-miner-rss --enable-miner-flickr --enable-miner-evolution --enable-poppler --enable-exempi --enable-libiptcdata --enable-libjpeg --enable-libtiff --enable-libvorbis --enable-libflac --enable-libgsf --enable-playlist --enable-tracker-preferences --enable-tracker-search-bar --enable-tracker-status-icon --with-enca && make
datadir: command not found
Found Vala 0.11.2
Copying file ABOUT-NLS
Copying file config.rpath
Copying file m4/codeset.m4
Copying file m4/gettext.m4
Copying file m4/glibc2.m4
Copying file m4/glibc21.m4
Copying file m4/iconv.m4
Copying file m4/intdiv0.m4
Copying file m4/intl.m4
Copying file m4/intldir.m4
Copying file m4/intlmacosx.m4
Copying file m4/intmax.m4
Copying file m4/inttypes-pri.m4
Copying file m4/inttypes_h.m4
Copying file m4/lcmessage.m4
Copying file m4/lib-ld.m4
Copying file m4/lib-link.m4
Copying file m4/lib-prefix.m4
Copying file m4/lock.m4
Copying file m4/longlong.m4
Copying file m4/nls.m4
Copying file m4/po.m4
Copying file m4/printf-posix.m4
Copying file m4/progtest.m4
Copying file m4/size_max.m4
Copying file m4/stdint_h.m4
Copying file m4/uintmax_t.m4
Copying file m4/visibility.m4
Copying file m4/wchar_t.m4
Copying file m4/wint_t.m4
Copying file m4/xsize.m4
Copying file po/
Copying file po/Makevars.template
Copying file po/Rules-quot
Copying file po/boldquot.sed
Copying file po/en@boldquot.header
Copying file po/en@quot.header
Copying file po/insert-header.sin
Copying file po/quot.sed
Copying file po/remove-potcdate.sin
autoreconf: Entering directory `.'
autoreconf: running: intltoolize --automake --copy --force
autoreconf: running: aclocal --force -I m4 ${ACLOCAL_FLAGS}
autoreconf: tracing
autoreconf: running: libtoolize --install --copy --force
libtoolize: putting auxiliary files in `.'.
libtoolize: copying file `./config.guess'
libtoolize: copying file `./config.sub'
libtoolize: copying file `./install-sh'
libtoolize: copying file `./'
libtoolize: putting macros in AC_CONFIG_MACRO_DIR, `m4'.
libtoolize: copying file `m4/libtool.m4'
libtoolize: copying file `m4/ltoptions.m4'
libtoolize: copying file `m4/ltsugar.m4'
libtoolize: copying file `m4/ltversion.m4'
libtoolize: copying file `m4/lt~obsolete.m4'
autoreconf: running: /usr/bin/autoconf --force
autoreconf: running: /usr/bin/autoheader --force
autoreconf: running: automake --add-missing --copy --force-missing installing `./compile' installing `./missing'
docs/tools/ installing `./depcomp'
src/libtracker-miner/ HAVE_INTROSPECTION does not appear in AM_CONDITIONAL installing `./INSTALL'
autoreconf: automake failed with exit status: 1


Still doesn't work here?
Comment 6 Javier Jardón (IRC: jjardon) 2010-12-10 17:51:32 UTC
Created attachment 176195 [details] [review]
Add introspection support in libtracker-miner.v2

Other approach: Add the introspection.m4 to the source tree so you do not depend on gobject introspection package
Comment 7 Martyn Russell 2011-05-03 08:50:40 UTC
Comment on attachment 176195 [details] [review]
Add introspection support in libtracker-miner.v2

Marking as committed because a variation of this patch was used in the end.
Comment 8 Martyn Russell 2011-05-03 08:52:06 UTC
Marking as Fixed, because we have introspection support now.